This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Outdated comment for __build_class__ in compile.c
Type: Stage: resolved
Components: Documentation Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: JelleZijlstra, docs@python, hauntsaninja, miss-islington
Priority: normal Keywords: patch

Created on 2022-02-23 03:31 by hauntsaninja, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 31522 merged hauntsaninja, 2022-02-23 03:32
PR 31652 merged miss-islington, 2022-03-03 05:33
PR 31653 merged miss-islington, 2022-03-03 05:33
Messages (4)
msg413768 - (view) Author: Shantanu (hauntsaninja) * Date: 2022-02-23 03:31
https://github.com/python/cpython/blob/cf345e945f48f54785799390c2e92c5310847bd4/Python/compile.c#L2537
```
    /* ultimately generate code for:
         <name> = __build_class__(<func>, <name>, *<bases>, **<keywords>)
       where:
         <func> is a function/closure created from the class body;
            it has a single argument (__locals__) where the dict
            (or MutableSequence) representing the locals is passed
```

`func` currently takes zero arguments. This was changed in https://github.com/python/cpython/commit/e8e14591ebb729b4fa19626ce245fa0811cf6f32 in Python 3.4
msg414405 - (view) Author: Jelle Zijlstra (JelleZijlstra) * (Python committer) Date: 2022-03-03 05:33
New changeset 81d968b7c30d5b41f3f28b297b7ee5345d569509 by Shantanu in branch 'main':
bpo-46831: Update __build_class__ comment (#31522)
https://github.com/python/cpython/commit/81d968b7c30d5b41f3f28b297b7ee5345d569509
msg414406 - (view) Author: miss-islington (miss-islington) Date: 2022-03-03 06:00
New changeset 1d428bb8c93120d449212e2a815988f28e33b868 by Miss Islington (bot) in branch '3.9':
bpo-46831: Update __build_class__ comment (GH-31522)
https://github.com/python/cpython/commit/1d428bb8c93120d449212e2a815988f28e33b868
msg414407 - (view) Author: miss-islington (miss-islington) Date: 2022-03-03 06:03
New changeset fa8c5ed9c80507670c756aa83ea872b8a92bcd1c by Miss Islington (bot) in branch '3.10':
bpo-46831: Update __build_class__ comment (GH-31522)
https://github.com/python/cpython/commit/fa8c5ed9c80507670c756aa83ea872b8a92bcd1c
History
Date User Action Args
2022-04-11 14:59:56adminsetgithub: 90987
2022-03-03 06:03:09miss-islingtonsetmessages: + msg414407
2022-03-03 06:00:08miss-islingtonsetmessages: + msg414406
2022-03-03 05:33:38JelleZijlstrasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2022-03-03 05:33:11miss-islingtonsetpull_requests: + pull_request29772
2022-03-03 05:33:07miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request29771
2022-03-03 05:33:06JelleZijlstrasetnosy: + JelleZijlstra
messages: + msg414405
2022-02-23 03:32:46hauntsaninjasetkeywords: + patch
stage: patch review
pull_requests: + pull_request29649
2022-02-23 03:31:57hauntsaninjacreate