This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Modernize `` by removing unused `sys.version_info` check
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.11
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: asvetlov, sobolevn, yselivanov
Priority: normal Keywords: patch

Created on 2022-01-30 14:38 by sobolevn, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 31023 merged sobolevn, 2022-01-30 14:39
Messages (3)
msg412148 - (view) Author: Nikita Sobolev (sobolevn) * (Python triager) Date: 2022-01-30 14:38
Right now `` contains this check on module-level:

if sys.version_info >= (3, 5):


Learning from other modules, we tend to remove lines like this when some python version reaches EOL. And since 3.4 is not support for a long time now, this condition is always true.

I propose to delete it.
msg412342 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2022-02-02 08:15
New changeset 3483aa65dfebfc60a87ea9db3f20da84be41f606 by Nikita Sobolev in branch 'main':
bpo-46583: remove unused `sys.version_info` check from `selectors` (GH-31023)
msg412343 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2022-02-02 08:36
The change should NOT be backported, it doesn't fix any bug but clears code a little
Date User Action Args
2022-04-11 14:59:55adminsetgithub: 90741
2022-02-02 08:36:54asvetlovsetmessages: + msg412343
versions: - Python 3.9, Python 3.10
2022-02-02 08:35:32asvetlovsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2022-02-02 08:15:30asvetlovsetmessages: + msg412342
2022-01-30 14:39:36sobolevnsetkeywords: + patch
stage: patch review
pull_requests: + pull_request29204
2022-01-30 14:38:15sobolevncreate