This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Modernize `test_asyncio/test_base_events.py`
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.11
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: asvetlov, corona10, sobolevn, yselivanov
Priority: normal Keywords: patch

Created on 2022-01-12 20:53 by sobolevn, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 30562 merged sobolevn, 2022-01-12 20:55
Messages (2)
msg410430 - (view) Author: Nikita Sobolev (sobolevn) * (Python triager) Date: 2022-01-12 20:53
Right now there's a special case for python3.4 in `Lib/test/test_asyncio/test_base_events.py` file.

Links:
- https://github.com/python/cpython/blob/0bbf30e2b910bc9c5899134ae9d73a8df968da35/Lib/test/test_asyncio/test_base_events.py#L24
- https://github.com/python/cpython/blob/0bbf30e2b910bc9c5899134ae9d73a8df968da35/Lib/test/test_asyncio/test_base_events.py#L599

Python3.4 is long gone, I propose to remove this special case.
PR is on its way :)
msg410492 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2022-01-13 14:28
New changeset f779faccd3a7a7e8c372492e858d021c449cdd85 by Nikita Sobolev in branch 'main':
bpo-46358: modernize `test_asyncio` (GH-30562)
https://github.com/python/cpython/commit/f779faccd3a7a7e8c372492e858d021c449cdd85
History
Date User Action Args
2022-04-11 14:59:54adminsetgithub: 90516
2022-01-13 15:00:28AlexWaygoodsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2022-01-13 14:28:10corona10setnosy: + corona10
messages: + msg410492
2022-01-12 22:06:34AlexWaygoodsetnosy: + asvetlov, yselivanov
2022-01-12 20:55:39sobolevnsetkeywords: + patch
stage: patch review
pull_requests: + pull_request28762
2022-01-12 20:53:36sobolevncreate