➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2022-01-11 21:22 by sobolevn, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 30547 | merged | sobolevn, 2022-01-11 21:25 | |
| Messages (4) | |||
|---|---|---|---|
| msg410333 - (view) | Author: Nikita Sobolev (sobolevn) *  |
Date: 2022-01-11 21:22 | |
There are several very old details in `test_typing`. Some examples: 1. `@skipUnless(sys.version_info >= (3, 3), 'ChainMap was added in 3.3')` https://github.com/python/cpython/blame/dce642f24418c58e67fa31a686575c980c31dd37/Lib/test/test_typing.py#L3583 Probably we don't care about `3.3` anymore, so this decorator cam be removed 2. Lib/test/mod_generics_cache.py has a specific path for 3.6, which has reached its EOL, so it can also be simplified 3. `ASYNCIO_TESTS` can be written as a regular code now (this is the one I am not 100% sure about, but let's see what the CI will say) PR is on its way! |
|||
| msg410334 - (view) | Author: Nikita Sobolev (sobolevn) * |
Date: 2022-01-11 21:33 | |
Alex, thanks a lot for fixing so many of my titles! Highly appreciated! |
|||
| msg410336 - (view) | Author: Alex Waygood (AlexWaygood) * |
Date: 2022-01-11 21:47 | |
Heh, no worries! |
|||
| msg410414 - (view) | Author: Guido van Rossum (gvanrossum) *  |
Date: 2022-01-12 16:48 | |
New changeset e2a9c8ef09cb7123d6b28852a323e6cc1f878b5b by Nikita Sobolev in branch 'main': bpo-46348: modernize `test_typing` (GH-30547) https://github.com/python/cpython/commit/e2a9c8ef09cb7123d6b28852a323e6cc1f878b5b |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:54 | admin | set | github: 90506 |
| 2022-01-12 22:07:54 | AlexWaygood | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2022-01-12 16:48:14 | gvanrossum | set | messages: + msg410414 |
| 2022-01-11 21:47:04 | AlexWaygood | set | messages: + msg410336 |
| 2022-01-11 21:33:30 | sobolevn | set | messages:
+ msg410334 components: + Tests, - Library (Lib) |
| 2022-01-11 21:31:20 | AlexWaygood | set | nosy:
+ gvanrossum, kj, AlexWaygood type: behavior title: Morernize `test_typing` -> Modernize `test_typing` |
| 2022-01-11 21:25:07 | sobolevn | set | keywords:
+ patch stage: patch review pull_requests: + pull_request28747 |
| 2022-01-11 21:22:44 | sobolevn | create | |