This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Enum tests: One branch is not covered in `Enum._convert_`
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.11
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ethan.furman Nosy List: ethan.furman, pablogsal, sobolevn
Priority: normal Keywords: patch

Created on 2022-01-07 23:15 by sobolevn, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 30472 merged sobolevn, 2022-01-07 23:16
PR 30510 merged sobolevn, 2022-01-10 09:06
Messages (5)
msg410053 - (view) Author: Nikita Sobolev (sobolevn) * (Python triager) Date: 2022-01-07 23:15
This branch is never covered: https://github.com/python/cpython/blob/c9dc1f491e8edb0bc433cde73190a3015d226891/Lib/enum.py#L831

I will send a PR in a moment :)
msg410069 - (view) Author: Ethan Furman (ethan.furman) * (Python committer) Date: 2022-01-08 01:49
Alex, thanks for nosying me.  Go ahead and make Enum issues assigned to me as well.  :-)
msg410108 - (view) Author: Ethan Furman (ethan.furman) * (Python committer) Date: 2022-01-08 19:43
New changeset 8d59d2563b914b7208779834895c080c70cd94dd by Nikita Sobolev in branch 'main':
bpo-46301: [Enum] test uncomparable values in `_convert_` (GH-30472)
https://github.com/python/cpython/commit/8d59d2563b914b7208779834895c080c70cd94dd
msg410173 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2022-01-09 22:25
Seems that this PR has broken the refleak buildbots:

https://buildbot.python.org/all/#/builders/320/builds/269/
https://buildbot.python.org/all/#/builders/384/builds/255

According to our buildbot policy, if this is not fixed in 24h we will need to revert
msg410245 - (view) Author: Ethan Furman (ethan.furman) * (Python committer) Date: 2022-01-10 19:09
New changeset 582286d71c7ee61f5376a846a83c7be4a5727636 by Nikita Sobolev in branch 'main':
bpo-46301: [Enum] fix refleak tests (GH30510)
https://github.com/python/cpython/commit/582286d71c7ee61f5376a846a83c7be4a5727636
History
Date User Action Args
2022-04-11 14:59:54adminsetgithub: 90459
2022-01-10 19:09:11ethan.furmansetmessages: + msg410245
2022-01-10 09:06:35sobolevnsetpull_requests: + pull_request28714
2022-01-10 04:07:22ethan.furmansetmessages: - msg410184
2022-01-10 03:46:13ethan.furmansetmessages: + msg410184
2022-01-09 22:25:29pablogsalsetnosy: + pablogsal
messages: + msg410173
2022-01-08 19:44:51ethan.furmansetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2022-01-08 19:43:49ethan.furmansetmessages: + msg410108
2022-01-08 01:49:49ethan.furmansetmessages: + msg410069
2022-01-08 01:48:50ethan.furmansetassignee: ethan.furman
2022-01-08 01:23:03AlexWaygoodsetnosy: + ethan.furman

title: One branch is not covered in `Enum._convert_` -> Enum tests: One branch is not covered in `Enum._convert_`
2022-01-07 23:16:32sobolevnsetkeywords: + patch
stage: patch review
pull_requests: + pull_request28675
2022-01-07 23:15:32sobolevncreate