➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-12-07 17:34 by vstinner, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 29987 | merged | vstinner, 2021-12-08 11:44 | |
| Messages (3) | |||
|---|---|---|---|
| msg407955 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2021-12-07 17:34 | |
The PyUnicode_CHECK_INTERNED() macro uses the PyASCIIObject structure which is *excluded* from the limited C API:
/* Use only if you know it's a string */
#define PyUnicode_CHECK_INTERNED(op) \
(((PyASCIIObject *)(op))->state.interned)
Using this macro in the limited C API doesn't work.
I propose to remove it from the limited C API.
IMO it's not a good idea to fix the function in the limited C API by converting it to a regular function hiding the implementation details and so working at the ABI level. We should not expose such "implementation detail" (if a string is "interned or not") in the *limited* C API.
|
|||
| msg408007 - (view) | Author: Petr Viktorin (petr.viktorin) * |
Date: 2021-12-08 10:41 | |
+1, PyUnicodeObject/PyASCIIObject is excluded from the limited API since Python 3.2, so it wasn't possible to use this macro. |
|||
| msg408086 - (view) | Author: miss-islington (miss-islington) | Date: 2021-12-09 08:58 | |
New changeset 73325bbe774b16891f999fb557177206470676b1 by Victor Stinner in branch 'main': bpo-46007: Exclude PyUnicode_CHECK_INTERNED() from limited C API (GH-29987) https://github.com/python/cpython/commit/73325bbe774b16891f999fb557177206470676b1 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:53 | admin | set | github: 90165 |
| 2021-12-09 09:00:19 | vstinner | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2021-12-09 08:58:21 | miss-islington | set | nosy:
+ miss-islington messages: + msg408086 |
| 2021-12-08 11:44:02 | vstinner | set | keywords:
+ patch stage: patch review pull_requests: + pull_request28210 |
| 2021-12-08 10:41:28 | petr.viktorin | set | messages: + msg408007 |
| 2021-12-07 17:34:31 | vstinner | set | nosy:
+ petr.viktorin |
| 2021-12-07 17:34:25 | vstinner | create | |