classification
Title: Azure Pipelines currently failing
Type: compile error Stage: resolved
Components: Build Versions: Python 3.11, Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: christian.heimes, gvanrossum, miss-islington, steve.dower, vstinner
Priority: high Keywords: easy (C), patch

Created on 2021-11-24 18:50 by gvanrossum, last changed 2021-11-24 22:00 by christian.heimes. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 29761 merged christian.heimes, 2021-11-24 19:20
PR 29765 merged miss-islington, 2021-11-24 20:12
Messages (8)
msg406945 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2021-11-24 18:50
E.g. https://dev.azure.com/Python/cpython/_build/results?buildId=92084&view=results
msg406946 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2021-11-24 18:51
Seems we lost the C++ handling in Include/cpython/initconfig.h:

#ifdef __cplusplus
extern "C" {
#endif

<full body of file>

#ifdef __cplusplus
}
#endif
msg406947 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2021-11-24 18:59
Also, we should define $env:IncludeUWP="true" in the Windows PR tests. That will build extra binaries every time (that we ship in the Windows Store) and would catch this issue earlier.
msg406950 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2021-11-24 19:03
Christian thinks that a PR by Victor broke this (GH-29488 / bpo-39026)
msg406956 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-11-24 20:12
New changeset f4afc53bf68c8ded20b281cd1baa88a679b4a3fd by Christian Heimes in branch 'main':
bpo-45893: Add missing extern C to initconfig.h (GH-29761)
https://github.com/python/cpython/commit/f4afc53bf68c8ded20b281cd1baa88a679b4a3fd
msg406963 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2021-11-24 21:33
> Seems we lost the C++ handling in Include/cpython/initconfig.h

I was never in initconfig.h since the PEP 587 (PyConfig C API) was implemented. I'm not sure why the build *started* to fail on Windows.

Thanks for fixing the issue ;-)
msg406965 - (view) Author: miss-islington (miss-islington) Date: 2021-11-24 21:57
New changeset cd85d91bc66a587ce2ba668c897a5ecf118733cc by Miss Islington (bot) in branch '3.10':
bpo-45893: Add missing extern C to initconfig.h (GH-29761)
https://github.com/python/cpython/commit/cd85d91bc66a587ce2ba668c897a5ecf118733cc
msg406966 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-11-24 22:00
You are welcome!
History
Date User Action Args
2021-11-24 22:00:12christian.heimessetstatus: open -> closed
resolution: fixed
messages: + msg406966

stage: patch review -> resolved
2021-11-24 21:57:52miss-islingtonsetmessages: + msg406965
2021-11-24 21:33:14vstinnersetmessages: + msg406963
2021-11-24 20:12:20miss-islingtonsetkeywords: + patch
nosy: + miss-islington
pull_requests: + pull_request28003
2021-11-24 20:12:16christian.heimessetmessages: + msg406956
2021-11-24 19:21:13christian.heimessetkeywords: - patch
type: compile error
versions: + Python 3.10
2021-11-24 19:20:15christian.heimessetkeywords: + patch
stage: patch review
pull_requests: + pull_request27999
2021-11-24 19:03:36gvanrossumsetnosy: + vstinner
messages: + msg406950
2021-11-24 18:59:55steve.dowersetmessages: + msg406947
2021-11-24 18:51:34steve.dowersetkeywords: + easy (C)

messages: + msg406946
versions: + Python 3.11
2021-11-24 18:50:48gvanrossumsetnosy: + christian.heimes
2021-11-24 18:50:21gvanrossumcreate