This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Inaccurate phrasing in extending/newtypes_tutorial
Type: Stage: resolved
Components: Documentation Versions: Python 3.11
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: JelleZijlstra, docs@python, miss-islington, rtobar, rtobar2
Priority: normal Keywords: patch

Created on 2021-11-12 02:55 by rtobar2, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 29529 merged rtobar, 2021-11-12 03:13
PR 32320 merged miss-islington, 2022-04-05 02:36
PR 32321 merged JelleZijlstra, 2022-04-05 02:41
Messages (5)
msg406185 - (view) Author: Rodrigo Tobar (rtobar2) * Date: 2021-11-12 02:55
In `extending/newtypes_tutorial.rst` the following phrase appears:

"[...], containing a pointer to a type object and a reference count (these can be accessed using the macros :c:macro:`Py_REFCNT` and c:macro:`Py_TYPE` respectively)."

I believe it should read "using the macros :c:macro:`Py_TYPE` and c:macro:`Py_REFCNT` respectively" to follow the same order in which the fields are described.

I'll put forward a patch. It seems this phrase goes way back a few python versions, but I'm tagging 3.11 here only.
msg416722 - (view) Author: Jelle Zijlstra (JelleZijlstra) * (Python committer) Date: 2022-04-05 02:36
New changeset b275267aa7d44ec90fa435c9cb1610c549da745a by rtobar in branch 'main':
bpo-45790: List macros in same order in which fields are described (GH-29529)
msg416724 - (view) Author: Jelle Zijlstra (JelleZijlstra) * (Python committer) Date: 2022-04-05 02:44
Thanks for noticing and fixing!
msg416730 - (view) Author: miss-islington (miss-islington) Date: 2022-04-05 02:57
New changeset f4e711bb49881deb1f07a685878646cd5cdee50f by Miss Islington (bot) in branch '3.10':
bpo-45790: List macros in same order in which fields are described (GH-29529)
msg416752 - (view) Author: Jelle Zijlstra (JelleZijlstra) * (Python committer) Date: 2022-04-05 05:28
New changeset d1fb16ae286795abe3e9da86332c891b4b18826f by Jelle Zijlstra in branch '3.9':
[3.9] bpo-45790: List macros in same order in which fields are described (GH-29529) (GH-32321)
Date User Action Args
2022-04-11 14:59:52adminsetgithub: 89948
2022-04-05 05:28:25JelleZijlstrasetmessages: + msg416752
2022-04-05 02:57:27miss-islingtonsetmessages: + msg416730
2022-04-05 02:44:46JelleZijlstrasetstatus: open -> closed
resolution: fixed
messages: + msg416724

stage: patch review -> resolved
2022-04-05 02:41:00JelleZijlstrasetpull_requests: + pull_request30382
2022-04-05 02:36:45JelleZijlstrasetnosy: + JelleZijlstra
messages: + msg416722
2022-04-05 02:36:42miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request30381
2021-11-12 03:13:23rtobarsetkeywords: + patch
nosy: + rtobar

pull_requests: + pull_request27779
stage: patch review
2021-11-12 02:55:53rtobar2create