classification
Title: Production tokens are not clickable
Type: Stage: resolved
Components: Documentation Versions: Python 3.11, Python 3.10, Python 3.9, Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: Arthur-Milchior, docs@python, lukasz.langa, miss-islington
Priority: normal Keywords: patch

Created on 2021-10-28 03:04 by Arthur-Milchior, last changed 2021-11-18 18:37 by lukasz.langa. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 29260 merged Arthur-Milchior, 2021-10-28 03:09
PR 29621 merged miss-islington, 2021-11-18 16:06
PR 29623 closed lukasz.langa, 2021-11-18 16:33
Messages (4)
msg405147 - (view) Author: Arthur Milchior (Arthur-Milchior) * Date: 2021-10-28 03:04
In the current documentation, production tokens are not clickable. For example in https://docs.python.org/3/reference/expressions.html#yield-expressions , you highlight `yield_from` as a token but do not link to it.
I suppose that the goal, when using :token:`yeld_from`, was to ensure that the token links to its definition. However, Sphinx require to use :token:`~python-grammar:yeld_from` for the link to appear. 

I suggest adding ~python-grammar after each token:.
msg406546 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-11-18 16:06
New changeset 32959108f9c543e3cb9f2b68bbc782bddded6f42 by Arthur Milchior in branch 'main':
bpo-45640: [docs] Tokens are now clickable (GH-29260)
https://github.com/python/cpython/commit/32959108f9c543e3cb9f2b68bbc782bddded6f42
msg406554 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-11-18 16:28
New changeset 252d83cbf1bf0a6ac22a1347e760cd3e551bb834 by Miss Islington (bot) in branch '3.10':
bpo-45640: [docs] Tokens are now clickable (GH-29260) (GH-29621)
https://github.com/python/cpython/commit/252d83cbf1bf0a6ac22a1347e760cd3e551bb834
msg406559 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-11-18 18:37
We won't be backporting this to 3.9 due to `make suspicious` being faulty on this version. More details on GH-29623.

So this is fixed on 3.10 and 3.11. Thanks, Arthur! ✨ 🍰 ✨
History
Date User Action Args
2021-11-18 18:37:58lukasz.langasetstatus: open -> closed
resolution: fixed
messages: + msg406559

stage: patch review -> resolved
2021-11-18 16:33:14lukasz.langasetpull_requests: + pull_request27857
2021-11-18 16:28:48lukasz.langasetmessages: + msg406554
2021-11-18 16:06:48miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request27856
2021-11-18 16:06:46lukasz.langasetnosy: + lukasz.langa
messages: + msg406546
2021-10-28 03:09:41Arthur-Milchiorsetkeywords: + patch
stage: patch review
pull_requests: + pull_request27525
2021-10-28 03:04:26Arthur-Milchiorcreate