msg405060 - (view) |
Author: Maciej Olko (Maciej Olko) * |
Date: 2021-10-26 22:34 |
Since the release of Docutils 0.18 today building Python documentation fails.
In CPython repository we have Sphinx pinned to 3.2.1, which has too loose requirement for Docutils version in install_requires – docutils>=0.12.
Example of failing build: https://github.com/python/python-docs-pl/runs/4009459257.
My suggestion is to pin down docutils in docs requirements.
|
msg405061 - (view) |
Author: Maciej Olko (Maciej Olko) * |
Date: 2021-10-26 22:45 |
The pin can be removed after bumping Sphinx to at least 3.5.4, which introduced upper limit for docutils version.
https://github.com/sphinx-doc/sphinx/commit/9263eea38379822e053c67ad1d17036d724c5e41
|
msg405099 - (view) |
Author: Ned Deily (ned.deily) * |
Date: 2021-10-27 14:21 |
New changeset bcee6aa31550cfecdc3acecbd0e4447bb0051887 by m-aciek in branch 'main':
bpo-45618: Fix documentation build by pinning Docutils version to 0.17.1 (GH-29230)
https://github.com/python/cpython/commit/bcee6aa31550cfecdc3acecbd0e4447bb0051887
|
msg405101 - (view) |
Author: Ned Deily (ned.deily) * |
Date: 2021-10-27 14:37 |
New changeset 2b7b7c7320cd856df5439afc3c984873678c27d8 by Miss Islington (bot) in branch '3.10':
bpo-45618: Fix documentation build by pinning Docutils version to 0.17.1 (GH-29230) (GH-29240)
https://github.com/python/cpython/commit/2b7b7c7320cd856df5439afc3c984873678c27d8
|
msg405102 - (view) |
Author: Ned Deily (ned.deily) * |
Date: 2021-10-27 15:04 |
New changeset 30c1f18ee62cef301e18488b80b4d329290f7b95 by Ned Deily in branch '3.9':
[3.9] bpo-45618: Fix documentation build by pinning Docutils version to 0.17.1 (GH-29230) (GH-29241)
https://github.com/python/cpython/commit/30c1f18ee62cef301e18488b80b4d329290f7b95
|
msg405118 - (view) |
Author: Ned Deily (ned.deily) * |
Date: 2021-10-27 17:57 |
All of the open branches are affected by this since we also have to build documentation for security-fix-only branches when releases. PRs for 3.7 and 3.6 forthcoming.
|
msg405125 - (view) |
Author: Maciej Olko (Maciej Olko) * |
Date: 2021-10-27 21:19 |
For what it's worth I have just successfully built documentation on 3.7 and 3.6 branches locally. It looks like Sphinx 2.3.1 used there doesn't use this part of docutils API that have changed recently.
Sphinx 2.3.1 has requirement of "docutils>=0.12", just like 3.2.1.
We can pin docutils version to current (0.18) "just in case" to prevent a breakage in the future or do nothing – maybe it won't break – maybe the docutils API used is narrow enough.
|
msg405134 - (view) |
Author: Maciej Olko (Maciej Olko) * |
Date: 2021-10-27 22:07 |
It occurs that the documentation builds without warnings on most recent Sphinx -- version 4.2.0. Probably we should bump the version in 3.11, 3.10 and 3.9 to 4.2.0. That would enable us to remove the pin on docutils.
|
msg405135 - (view) |
Author: Maciej Olko (Maciej Olko) * |
Date: 2021-10-27 22:09 |
I'm sorry for the confusion. I might have make more checking on my side before proposing a fix.
|
msg405229 - (view) |
Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-10-28 19:08 |
New changeset f2407144347fafcd69c2ade41b5d9c3fb07b59ef by Ned Deily in branch '3.8':
[3.9] bpo-45618: Fix documentation build by pinning Docutils version to 0.17.1 (GH-29230) (GH-29241) (GH-29245)
https://github.com/python/cpython/commit/f2407144347fafcd69c2ade41b5d9c3fb07b59ef
|
msg405420 - (view) |
Author: miss-islington (miss-islington) |
Date: 2021-10-31 20:51 |
New changeset 14a4fce457033412278ca9a056787db424310dc3 by m-aciek in branch 'main':
bpo-45618: Update Sphinx version used to build the documentation to 4.2.0 (GH-29256)
https://github.com/python/cpython/commit/14a4fce457033412278ca9a056787db424310dc3
|
msg413665 - (view) |
Author: Ned Deily (ned.deily) * |
Date: 2022-02-21 17:58 |
New changeset 7a5850987010ca5cb0f1e2844cfe183935916e7e by Ned Deily in branch '3.7':
bpo-45618: Fix documentation build by pinning Docutils version to 0.17.1 (GH-31476)
https://github.com/python/cpython/commit/7a5850987010ca5cb0f1e2844cfe183935916e7e
|
msg415979 - (view) |
Author: Maciej Olko (Maciej Olko) * |
Date: 2022-03-24 23:04 |
After the Jinja version 3.1.0 release today [1], documentation builds fail for all stable branches. Sphinx in versions pinned on those branches fails with ImportError. [2]
Backporting 14a4fce457033412278ca9a056787db424310dc3 to 3.10 and 3.9 fixes the problem for them (build is successful with 4.2.0). For 3.8 and 3.7 pinning down Jinja is required (docs don't build smoothly with 4.2.0 for those branches).
Could some core developer help with the backports?
I am starting to work on PRs with pins for 3.8 and 3.7.
[1] https://jinja.palletsprojects.com/en/3.1.x/changes/#version-3-1-0
[2] % sphinx-build --version
Traceback (most recent call last):
File "…/cpython/Doc/./venv/bin/sphinx-build", line 5, in <module>
from sphinx.cmd.build import main
File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/cmd/build.py", line 25, in <module>
from sphinx.application import Sphinx
File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/application.py", line 42, in <module>
from sphinx.registry import SphinxComponentRegistry
File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/registry.py", line 24, in <module>
from sphinx.builders import Builder
File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/builders/__init__.py", line 26, in <module>
from sphinx.util import import_object, logging, rst, progress_message, status_iterator
File "…/cpython/Doc/venv/lib/python3.9/site-packages/sphinx/util/rst.py", line 22, in <module>
from jinja2 import environmentfilter
ImportError: cannot import name 'environmentfilter' from 'jinja2' (…/cpython/Doc/venv/lib/python3.9/site-packages/jinja2/__init__.py)
|
msg416017 - (view) |
Author: Ned Deily (ned.deily) * |
Date: 2022-03-25 20:48 |
This really should be handled in a new issue since the original fixes for all affected releases are already in the field. Moreover, we should be a bit careful about bumping the required Sphinx version for older releases as this has caused problems for downstream distributors of Python in the past. Can't we just pin the Jinja2 version for current releases?
|
msg416148 - (view) |
Author: Maciej Olko (Maciej Olko) * |
Date: 2022-03-28 08:03 |
> This really should be handled in a new issue since the original fixes for all affected releases are already in the field.
Sorry, I got suggested too much with expected fix which is common for both of those issues. Shall I create a new issue?
> Moreover, we should be a bit careful about bumping the required Sphinx version for older releases as this has caused problems for downstream distributors of Python in the past. Can't we just pin the Jinja2 version for current releases?
Didn't know about the problems for distributors. Definitely just pinning Jinja2 is enough.
|
msg416150 - (view) |
Author: Hugo van Kemenade (hugovk) * |
Date: 2022-03-28 08:24 |
> > This really should be handled in a new issue since the original fixes for all affected releases are already in the field.
> Sorry, I got suggested too much with expected fix which is common for both of those issues. Shall I create a new issue?
I created https://bugs.python.org/issue47138, let's continue there.
|
|
Date |
User |
Action |
Args |
2022-04-11 14:59:51 | admin | set | github: 89781 |
2022-03-28 13:55:34 | ned.deily | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
2022-03-28 13:55:11 | ned.deily | set | pull_requests:
- pull_request30194 |
2022-03-28 13:54:58 | ned.deily | set | pull_requests:
- pull_request30186 |
2022-03-28 08:24:56 | hugovk | set | nosy:
+ hugovk messages:
+ msg416150
|
2022-03-28 08:03:17 | Maciej Olko | set | messages:
+ msg416148 |
2022-03-26 00:25:00 | ned.deily | set | pull_requests:
- pull_request30201 |
2022-03-26 00:24:52 | ned.deily | set | pull_requests:
- pull_request30200 |
2022-03-26 00:22:38 | miss-islington | set | pull_requests:
+ pull_request30201 |
2022-03-26 00:20:08 | miss-islington | set | pull_requests:
+ pull_request30200 |
2022-03-25 20:48:45 | ned.deily | set | messages:
+ msg416017 |
2022-03-25 17:32:23 | Maciej Olko | set | pull_requests:
+ pull_request30194 |
2022-03-25 09:12:10 | Maciej Olko | set | stage: resolved -> patch review pull_requests:
+ pull_request30186 |
2022-03-24 23:04:16 | Maciej Olko | set | status: closed -> open resolution: fixed -> (no value) messages:
+ msg415979
versions:
- Python 3.6, Python 3.11 |
2022-02-21 17:58:59 | ned.deily | set | messages:
+ msg413665 |
2022-02-21 17:48:05 | ned.deily | set | pull_requests:
+ pull_request29606 |
2021-12-07 23:24:34 | pablogsal | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
2021-10-31 20:51:42 | miss-islington | set | messages:
+ msg405420 |
2021-10-28 19:08:46 | lukasz.langa | set | messages:
+ msg405229 |
2021-10-27 22:28:11 | Maciej Olko | set | pull_requests:
+ pull_request27520 |
2021-10-27 22:09:10 | Maciej Olko | set | messages:
+ msg405135 |
2021-10-27 22:07:05 | Maciej Olko | set | messages:
+ msg405134 |
2021-10-27 21:19:23 | Maciej Olko | set | messages:
+ msg405125 |
2021-10-27 17:57:03 | ned.deily | set | messages:
+ msg405118 versions:
+ Python 3.6, Python 3.7, Python 3.8 |
2021-10-27 16:53:21 | ned.deily | set | pull_requests:
+ pull_request27509 |
2021-10-27 15:04:53 | ned.deily | set | messages:
+ msg405102 |
2021-10-27 14:37:25 | ned.deily | set | messages:
+ msg405101 |
2021-10-27 14:34:25 | ned.deily | set | pull_requests:
+ pull_request27504 |
2021-10-27 14:21:50 | miss-islington | set | nosy:
+ miss-islington pull_requests:
+ pull_request27503
|
2021-10-27 14:21:38 | ned.deily | set | nosy:
+ ned.deily messages:
+ msg405099
|
2021-10-27 07:20:17 | erlendaasland | set | nosy:
+ erlendaasland
|
2021-10-27 03:55:31 | ned.deily | set | priority: normal -> release blocker nosy:
+ pablogsal, lukasz.langa, mdk
versions:
+ Python 3.9 |
2021-10-26 22:55:45 | Maciej Olko | set | keywords:
+ patch stage: patch review pull_requests:
+ pull_request27493 |
2021-10-26 22:45:06 | Maciej Olko | set | messages:
+ msg405061 |
2021-10-26 22:39:21 | Maciej Olko | set | versions:
+ Python 3.11 |
2021-10-26 22:39:10 | Maciej Olko | set | versions:
- Python 3.6, Python 3.7, Python 3.8, Python 3.9, Python 3.11 |
2021-10-26 22:34:59 | Maciej Olko | create | |