classification
Title: First sentence in docs for os.environ
Type: enhancement Stage: resolved
Components: Documentation Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: andrei.avk, docs@python, eryksun, kj, lukasz.langa, miss-islington
Priority: low Keywords: patch

Created on 2021-10-24 15:11 by andrei.avk, last changed 2021-10-29 20:53 by lukasz.langa. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 29204 merged andrei.avk, 2021-10-24 16:42
PR 29321 merged miss-islington, 2021-10-29 20:19
PR 29322 merged miss-islington, 2021-10-29 20:19
Messages (7)
msg404934 - (view) Author: Andrei Kulakov (andrei.avk) * (Python triager) Date: 2021-10-24 15:11
In os.eviron docs:

https://docs.python.org/3.11/library/os.html#os.environ

A mapping object representing the string environment.

Should that be "... the process environment." ?
msg404935 - (view) Author: Eryk Sun (eryksun) * (Python triager) Date: 2021-10-24 15:25
The os.environ description appears to be worded as the "string environment" in contrast to the os.environb "environment as byte strings". I like the emphasis on the "process environment". How about "A mapping object of key and value strings that represent the process environment"?
msg404937 - (view) Author: Andrei Kulakov (andrei.avk) * (Python triager) Date: 2021-10-24 16:44
Eryk: sounds much better and clearer I think, I've put up a PR (that also does the same update to os.environb).
msg405335 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-10-29 20:18
New changeset b17cfd150f4dc2816975d304a71110a2d445eaf0 by andrei kulakov in branch 'main':
bpo-45600: Enhanced / clarified the docs for os.environ and os.environb (GH-29204)
https://github.com/python/cpython/commit/b17cfd150f4dc2816975d304a71110a2d445eaf0
msg405341 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-10-29 20:45
New changeset 0538351fcaa320e62cb4ef92ec629b7e24a73e9c by Miss Islington (bot) in branch '3.10':
bpo-45600: Enhanced / clarified the docs for os.environ and os.environb (GH-29204) (GH-29322)
https://github.com/python/cpython/commit/0538351fcaa320e62cb4ef92ec629b7e24a73e9c
msg405342 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-10-29 20:53
New changeset 3ec1124de289496efabc43a02cc88b3c59e1e238 by Miss Islington (bot) in branch '3.9':
bpo-45600: Enhanced / clarified the docs for os.environ and os.environb (GH-29204) (GH-29321)
https://github.com/python/cpython/commit/3ec1124de289496efabc43a02cc88b3c59e1e238
msg405343 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-10-29 20:53
Thanks, Andrei! ✨ 🍰 ✨
History
Date User Action Args
2021-10-29 20:53:34lukasz.langasetstatus: open -> closed
versions: + Python 3.9, Python 3.10
messages: + msg405343

resolution: fixed
stage: patch review -> resolved
2021-10-29 20:53:09lukasz.langasetmessages: + msg405342
2021-10-29 20:45:41lukasz.langasetmessages: + msg405341
2021-10-29 20:19:44miss-islingtonsetpull_requests: + pull_request27592
2021-10-29 20:19:40miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request27591
2021-10-29 20:18:49lukasz.langasetnosy: + lukasz.langa
messages: + msg405335
2021-10-24 16:44:30andrei.avksetnosy: + kj
2021-10-24 16:44:09andrei.avksetmessages: + msg404937
2021-10-24 16:42:54andrei.avksetkeywords: + patch
stage: patch review
pull_requests: + pull_request27473
2021-10-24 15:25:04eryksunsetnosy: + eryksun
messages: + msg404935
2021-10-24 15:11:07andrei.avkcreate