This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix test_shelve and make it discoverable
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: lukasz.langa, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2021-10-17 10:15 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 29003 merged serhiy.storchaka, 2021-10-17 10:20
PR 29305 merged serhiy.storchaka, 2021-10-29 08:59
PR 29306 merged serhiy.storchaka, 2021-10-29 09:45
Messages (5)
msg404133 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-10-17 10:15
test_shelve was intended to run some tests for all underlying dbm implementation, but since b17acad68ea21c60dbc2088644f2934032304628 (at May 2008) it runs them with the same implementation.

The proposed PR fixes this regression and also makes test_shelve discoverable, so it can be run with the unittest module.
msg404134 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-10-17 10:19
Also it was only tested with pickle protocols 0, 1 and 2. Now it will be tested with all pickle protocols.
msg404772 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-10-22 14:15
New changeset b781cc3bfce7c052728b06aad9f1a467cced289d by Serhiy Storchaka in branch 'main':
bpo-45502: Fix test_shelve (GH-29003)
https://github.com/python/cpython/commit/b781cc3bfce7c052728b06aad9f1a467cced289d
msg405295 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-10-29 09:40
New changeset 6b867022d926be9fcc6f8038fb1093ba8c348ca5 by Serhiy Storchaka in branch '3.10':
[3.10] bpo-45502: Fix test_shelve (GH-29003) (GH-29305)
https://github.com/python/cpython/commit/6b867022d926be9fcc6f8038fb1093ba8c348ca5
msg405300 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-10-29 10:18
New changeset a043706f907e82ee6a562005991ff0b896a4e64d by Serhiy Storchaka in branch '3.9':
[3.9] [3.10] bpo-45502: Fix test_shelve (GH-29003) (GH-29305) (GH-29306)
https://github.com/python/cpython/commit/a043706f907e82ee6a562005991ff0b896a4e64d
History
Date User Action Args
2022-04-11 14:59:51adminsetgithub: 89665
2021-10-29 10:19:07serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2021-10-29 10:18:38serhiy.storchakasetmessages: + msg405300
2021-10-29 09:45:53serhiy.storchakasetpull_requests: + pull_request27575
2021-10-29 09:40:27serhiy.storchakasetmessages: + msg405295
2021-10-29 08:59:48serhiy.storchakasetpull_requests: + pull_request27574
2021-10-22 14:15:02lukasz.langasetnosy: + lukasz.langa
messages: + msg404772
2021-10-17 10:21:20serhiy.storchakalinkissue45229 dependencies
2021-10-17 10:20:45serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request27285
2021-10-17 10:19:43serhiy.storchakasetmessages: + msg404134
2021-10-17 10:15:57serhiy.storchakacreate