This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Rewrite test_dbm
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: corona10, lukasz.langa, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2021-10-17 09:55 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 29002 merged serhiy.storchaka, 2021-10-17 09:59
PR 29069 merged lukasz.langa, 2021-10-19 19:48
PR 29074 merged lukasz.langa, 2021-10-19 20:48
Messages (5)
msg404131 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-10-17 09:55
* Generate test classes at import time. It allows to filter them when run with unittest. E.g: "./python -m unittest test.test_dbm.TestCase_gnu -v".
* Create a database class in a new directory which will be removed after test. It guarantees that all created files and directories be removed and will not conflict with other dbm tests.
* Restore dbm._defaultmod after tests. Previously it was set to the last dbm module (dbm.dumb) which affected other tests.
* Enable the whichdb test for dbm.dumb.
* Move test_keys to the correct test class. It does not test whichdb().
* Remove some outdated code and comments.
msg404336 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-10-19 19:11
New changeset 975b94b9de969777218e96a9950c1dab2dab65a0 by Serhiy Storchaka in branch 'main':
bpo-45500: Rewrite test_dbm (GH-29002)
https://github.com/python/cpython/commit/975b94b9de969777218e96a9950c1dab2dab65a0
msg404346 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-10-19 20:21
New changeset 325b2c223453203b2fa9ce7b9bcebdbef03adf70 by Łukasz Langa in branch '3.10':
[3.10] bpo-45500: Rewrite test_dbm (GH-29002) (GH-29069)
https://github.com/python/cpython/commit/325b2c223453203b2fa9ce7b9bcebdbef03adf70
msg404399 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2021-10-20 08:06
New changeset d46b2217d13bbcf8145da8c12a487ba775d6f162 by Łukasz Langa in branch '3.9':
[3.9] bpo-45500: Rewrite test_dbm (GH-29002) (GH-29074)
https://github.com/python/cpython/commit/d46b2217d13bbcf8145da8c12a487ba775d6f162
msg404401 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-10-20 08:29
Thanks Łukasz and Dong-hee Na.
History
Date User Action Args
2022-04-11 14:59:51adminsetgithub: 89663
2021-10-20 08:29:13serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg404401

stage: patch review -> resolved
2021-10-20 08:06:54corona10setnosy: + corona10
messages: + msg404399
2021-10-19 20:48:29lukasz.langasetpull_requests: + pull_request27342
2021-10-19 20:21:07lukasz.langasetmessages: + msg404346
2021-10-19 19:48:15lukasz.langasetpull_requests: + pull_request27337
2021-10-19 19:11:36lukasz.langasetnosy: + lukasz.langa
messages: + msg404336
2021-10-17 10:21:57serhiy.storchakalinkissue45229 dependencies
2021-10-17 09:59:00serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request27284
2021-10-17 09:55:33serhiy.storchakacreate