This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Decimal test and benchmark are broken
Type: behavior Stage: resolved
Components: Demos and Tools Versions: Python 3.11, Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: corona10, mark.dickinson, miss-islington, serhiy.storchaka, vstinner
Priority: normal Keywords: patch

Created on 2021-09-30 15:26 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 28680 merged corona10, 2021-10-01 13:26
PR 28681 merged miss-islington, 2021-10-01 13:49
Messages (4)
msg402964 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-09-30 15:26
The test and the benchmark for the decimal module are broken in 3.10+.

$ ./python Modules/_decimal/tests/deccheck.py
Traceback (most recent call last):
  File "/home/serhiy/py/cpython/Modules/_decimal/tests/deccheck.py", line 50, in <module>
    from test.support import import_fresh_module
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ImportError: cannot import name 'import_fresh_module' from 'test.support' (/home/serhiy/py/cpython/Lib/test/support/__init__.py)

$ ./python Modules/_decimal/tests/bench.py
Traceback (most recent call last):
  File "/home/serhiy/py/cpython/Modules/_decimal/tests/bench.py", line 11, in <module>
    from test.support import import_fresh_module
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ImportError: cannot import name 'import_fresh_module' from 'test.support' (/home/serhiy/py/cpython/Lib/test/support/__init__.py)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/serhiy/py/cpython/Modules/_decimal/tests/bench.py", line 13, in <module>
    from test.test_support import import_fresh_module
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ImportError: cannot import name 'import_fresh_module' from 'test.test_support' (/home/serhiy/py/cpython/Lib/test/test_support.py)


Modules/_decimal/tests/bench.py
msg403015 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2021-10-01 13:49
New changeset 9eed75fde226cec5a02301cfac1dc8039b5a183e by Dong-hee Na in branch 'main':
bpo-45332: Fix broken Decimal test and benchmark (GH-28680)
https://github.com/python/cpython/commit/9eed75fde226cec5a02301cfac1dc8039b5a183e
msg403017 - (view) Author: miss-islington (miss-islington) Date: 2021-10-01 14:16
New changeset 282992b36f9fe27183037051f3b37210884600af by Miss Islington (bot) in branch '3.10':
bpo-45332: Fix broken Decimal test and benchmark (GH-28680)
https://github.com/python/cpython/commit/282992b36f9fe27183037051f3b37210884600af
msg403018 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2021-10-01 14:18
Now the code is fixed.
Thanks Serhiy for the report and review :)
History
Date User Action Args
2022-04-11 14:59:50adminsetgithub: 89495
2021-10-01 14:18:19corona10setstatus: open -> closed
resolution: fixed
messages: + msg403018

stage: patch review -> resolved
2021-10-01 14:16:45miss-islingtonsetmessages: + msg403017
2021-10-01 13:49:55miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request27044
2021-10-01 13:49:54corona10setmessages: + msg403015
2021-10-01 13:26:09corona10setkeywords: + patch
nosy: + corona10

pull_requests: + pull_request27043
stage: patch review
2021-09-30 16:33:51mark.dickinsonsetnosy: + mark.dickinson
2021-09-30 15:26:12serhiy.storchakacreate