This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Improve specialization stats for LOAD_METHOD and BINARY_SUBSCR
Type: Stage: resolved
Components: Interpreter Core Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Mark.Shannon Nosy List: Mark.Shannon, kj, vstinner
Priority: normal Keywords: patch

Created on 2021-09-15 12:24 by Mark.Shannon, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 28352 merged Mark.Shannon, 2021-09-15 12:42
PR 28357 merged kj, 2021-09-15 16:15
Messages (5)
msg401823 - (view) Author: Mark Shannon (Mark.Shannon) * (Python committer) Date: 2021-09-15 12:24
The stats for BINARY_SUBSCR and to a lesser amount LOAD_METHOD don't tell us much about what isn't being specialized.

We should refine the stats to give us a better idea of what to optimize for.
msg401839 - (view) Author: Mark Shannon (Mark.Shannon) * (Python committer) Date: 2021-09-15 13:55
New changeset 11cdf2a6702639571554cbf3f69f57d688564540 by Mark Shannon in branch 'main':
bpo-45203: Cleanup stats gathering code for LOAD_METHOD (GH-28352)
https://github.com/python/cpython/commit/11cdf2a6702639571554cbf3f69f57d688564540
msg401844 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2021-09-15 15:42
load_method_fail_kind() added by commit 11cdf2a6702639571554cbf3f69f57d688564540 introduced a compiler (GCC) warning:

Python/specialize.c: In function 'load_method_fail_kind':
Python/specialize.c:878:1: warning: control reaches end of non-void function [-Wreturn-type]
  878 | }
      | ^
msg402023 - (view) Author: Ken Jin (kj) * (Python committer) Date: 2021-09-17 09:48
New changeset 4857e53890408fd5a8ee0e83c0250dd5355b3de3 by Ken Jin in branch 'main':
bpo-45203: fix compiler warnings (GH-28357)
https://github.com/python/cpython/commit/4857e53890408fd5a8ee0e83c0250dd5355b3de3
msg403590 - (view) Author: Ken Jin (kj) * (Python committer) Date: 2021-10-10 14:40
I'm closing this as there doesn't seem to be anything left to do. Please do reopen this issue if you feel that isn't the case.
History
Date User Action Args
2022-04-11 14:59:50adminsetgithub: 89366
2021-10-10 14:40:07kjsetstatus: open -> closed
resolution: fixed
messages: + msg403590

stage: patch review -> resolved
2021-09-17 09:48:48kjsetmessages: + msg402023
2021-09-15 16:15:34kjsetnosy: + kj
pull_requests: + pull_request26771
2021-09-15 15:42:39vstinnersetnosy: + vstinner
messages: + msg401844
2021-09-15 13:55:58Mark.Shannonsetmessages: + msg401839
2021-09-15 12:42:38Mark.Shannonsetkeywords: + patch
stage: patch review
pull_requests: + pull_request26766
2021-09-15 12:24:20Mark.Shannoncreate