This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Incorrect use of requires_zlib in test_bdist_rpm
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: dstufft, eric.araujo, miss-islington, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2021-09-13 07:46 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 28305 merged serhiy.storchaka, 2021-09-13 07:48
PR 28308 merged miss-islington, 2021-09-13 11:10
PR 28309 merged miss-islington, 2021-09-13 11:10
Messages (5)
msg401690 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-09-13 07:46
requires_zlib is a decorator factory which returns a decorator, not a decorator. It should always be followed by parenthesis. In Lib/distutils/tests/test_bdist_rpm.py it is used improperly, so the corresponding tests were never ran.
msg401695 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-09-13 11:10
New changeset 9260e6739865c966c3ec6c5c289e0b96f848403e by Serhiy Storchaka in branch 'main':
bpo-45182: Fix incorrect use of requires_zlib in test_bdist_rpm (GH-28305)
https://github.com/python/cpython/commit/9260e6739865c966c3ec6c5c289e0b96f848403e
msg401699 - (view) Author: miss-islington (miss-islington) Date: 2021-09-13 11:35
New changeset 2f1d9bca144f3bbb4199111f4763ef05daea8526 by Miss Islington (bot) in branch '3.10':
bpo-45182: Fix incorrect use of requires_zlib in test_bdist_rpm (GH-28305)
https://github.com/python/cpython/commit/2f1d9bca144f3bbb4199111f4763ef05daea8526
msg401702 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2021-09-13 13:41
At this point, it seems that there would be more value in reporting this to setuptools than on bpo.
msg401714 - (view) Author: miss-islington (miss-islington) Date: 2021-09-13 17:08
New changeset 218fe2cb798df32a722f61b95db280f6685ec3e6 by Miss Islington (bot) in branch '3.9':
bpo-45182: Fix incorrect use of requires_zlib in test_bdist_rpm (GH-28305)
https://github.com/python/cpython/commit/218fe2cb798df32a722f61b95db280f6685ec3e6
History
Date User Action Args
2022-04-11 14:59:49adminsetgithub: 89345
2021-09-13 21:24:16serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2021-09-13 17:08:43miss-islingtonsetmessages: + msg401714
2021-09-13 13:41:40eric.araujosetmessages: + msg401702
2021-09-13 11:35:17miss-islingtonsetmessages: + msg401699
2021-09-13 11:10:37miss-islingtonsetpull_requests: + pull_request26722
2021-09-13 11:10:33miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request26721
2021-09-13 11:10:22serhiy.storchakasetmessages: + msg401695
2021-09-13 07:48:30serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request26719
2021-09-13 07:46:28serhiy.storchakacreate