This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Use shared test loader when possible when running test suite
Type: Stage: resolved
Components: Tests Versions: Python 3.11
process
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: erlendaasland, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2021-09-12 23:12 by erlendaasland, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 28301 closed erlendaasland, 2021-09-12 23:12
Messages (3)
msg401674 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-09-12 23:12
Use unittest.defaultTestLoader instead of unittest.TestLoader() when possible, to avoid creating unnecessary many instances.
msg401688 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-09-13 07:15
See issue45181. Most of this code is gone.

Also, TestLoader has mutable attribute "errors". I am not sure that it is good idea to share it between unrelated tests.
msg401689 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-09-13 07:36
> Also, TestLoader has mutable attribute "errors". I am not sure that it is good idea to share it between unrelated tests.

Noted. I'm closing this.
History
Date User Action Args
2022-04-11 14:59:49adminsetgithub: 89340
2021-09-13 07:36:22erlendaaslandsetstatus: open -> closed
resolution: rejected
messages: + msg401689

stage: patch review -> resolved
2021-09-13 07:15:44serhiy.storchakasetmessages: + msg401688
2021-09-12 23:12:53erlendaaslandsetkeywords: + patch
stage: patch review
pull_requests: + pull_request26715
2021-09-12 23:12:23erlendaaslandcreate