Issue 45174: DragonflyBSD fix nis module build

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/89337

classification

Title:	DragonflyBSD fix nis module build
Type:	compile error	Stage:
Components:	Library (Lib), macOS	Versions:	Python 3.11

process

Status:	open	Resolution:
Dependencies:		Superseder:
Assigned To:		Nosy List:	brett.cannon, devnexen, ned.deily, ronaldoussoren, serhiy.storchaka
Priority:	normal	Keywords:

Created on 2021-09-11 20:34 by devnexen, last changed 2022-04-11 14:59 by admin.

Pull Requests
URL	Status	Linked	Edit
PR 28295	open	devnexen, 2021-09-11 20:34

Messages (1)
msg401650 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2021-09-11 22:07
The main difference between platforms is that the first argument of the foreach function is int on some platforms and unsigned long on others. PR 28295 fixes code not only on DragonflyBSD, but on FreeBSD and OpenBSD, where it is unsigned long. It is a bug fix which should be backported. But I afraid that it can break code on macOS. See f6067ec336e2eff1fc1cce90c67c20b0d4e80c22. I am not sure that I understand it completely. Are there compiler warnings when compile nismodule.c on macOS now? Does nis.cat() work on macOS now? If remove a cast to foreachfunc at line 255, will the compiler complain and how? Will nis.cat() work on macOS with PR 28295 applied?

msg401650 - (view)

Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer)

Date: 2021-09-11 22:07

The main difference between platforms is that the first argument of the foreach function is int on some platforms and unsigned long on others.

PR 28295 fixes code not only on DragonflyBSD, but on FreeBSD and OpenBSD, where it is unsigned long. It is a bug fix which should be backported. But I afraid that it can break code on macOS. See f6067ec336e2eff1fc1cce90c67c20b0d4e80c22. I am not sure that I understand it completely.

Are there compiler warnings when compile nismodule.c on macOS now? Does nis.cat() work on macOS now? If remove a cast to foreachfunc at line 255, will the compiler complain and how? Will nis.cat() work on macOS with PR 28295 applied?

History
Date	User	Action	Args
2022-04-11 14:59:49	admin	set	github: 89337
2021-09-11 22:07:47	serhiy.storchaka	set	nosy: + serhiy.storchaka, brett.cannon, ronaldoussoren, ned.deily messages: + msg401650 components: + macOS
2021-09-11 20:34:59	devnexen	create