This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Use subtests in test_peepholer
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.11
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: iritkatriel, lukasz.langa, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2021-09-09 00:19 by iritkatriel, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 28247 merged iritkatriel, 2021-09-09 00:21
Messages (4)
msg401428 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-09-09 00:19
test_peepholer has many tests that loop over test cases. Identifying them as subtests will make them easier to work with when something breaks.
msg401516 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-09-09 20:31
I am currently working on a feature which can be better in these cases that subTest(). It will allow to reduce the indentation level instead of increasing it.
msg401595 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-09-10 16:29
New changeset f8d624d6a571d6e773f53ad80aa93face7e8395b by Irit Katriel in branch 'main':
bpo-45144: use subTests in test_peepholer (GH-28247)
msg401596 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-09-10 16:30
We can refactor the tests to your new functionality once it's ready, Serhiy. In the mean time, this is fixed!
Date User Action Args
2022-04-11 14:59:49adminsetgithub: 89307
2021-09-10 16:30:52lukasz.langasetstatus: open -> closed
resolution: fixed
messages: + msg401596

stage: patch review -> resolved
2021-09-10 16:29:24lukasz.langasetnosy: + lukasz.langa
messages: + msg401595
2021-09-09 20:31:48serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg401516
2021-09-09 00:21:17iritkatrielsetkeywords: + patch
stage: patch review
pull_requests: + pull_request26667
2021-09-09 00:19:04iritkatrielcreate