➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-08-23 14:46 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 27904 | merged | serhiy.storchaka, 2021-08-23 14:51 | |
| PR 27908 | merged | miss-islington, 2021-08-23 18:05 | |
| PR 27910 | merged | lukasz.langa, 2021-08-23 18:17 | |
| Messages (5) | |||
|---|---|---|---|
| msg400139 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2021-08-23 14:46 | |
test_null_strings in Modules/_testcapimodule.c was initially added in 7580146b5c7025976f0907a9893e01dc3d3d3457 for testing PyObject_Str(NULL) and PyObject_Unicode(NULL). PyObject_Unicode() was removed in 3.0, so now the test calls PyObject_Str(NULL) twice that does not make sense. On other hand, PyObject_Bytes(NULL) and PyObject_Repr(NULL) are not tested. Additionally, there are now problems with unittest tests returning non-None. So this test should be completely rewritten. |
|||
| msg400158 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-08-23 18:05 | |
New changeset 4d689173861257c69adc6dc1dca4171946ddb57f by Serhiy Storchaka in branch 'main': bpo-44984: Rewrite test_null_strings in _testcapi (GH-27904) https://github.com/python/cpython/commit/4d689173861257c69adc6dc1dca4171946ddb57f |
|||
| msg400162 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-08-23 18:48 | |
New changeset b0df288c946143352237f28c78481d935ba1502c by Łukasz Langa in branch '3.9': [3.9] bpo-44984: Rewrite test_null_strings in _testcapi (GH-27904) (GH-27910) https://github.com/python/cpython/commit/b0df288c946143352237f28c78481d935ba1502c |
|||
| msg400171 - (view) | Author: miss-islington (miss-islington) | Date: 2021-08-23 19:30 | |
New changeset 6ff7fefc914541ec5afdd3c8193da80818cb0817 by Miss Islington (bot) in branch '3.10': bpo-44984: Rewrite test_null_strings in _testcapi (GH-27904) https://github.com/python/cpython/commit/6ff7fefc914541ec5afdd3c8193da80818cb0817 |
|||
| msg400181 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-08-23 22:54 | |
Thanks, Serhiy! ✨ 🍰 ✨ |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:49 | admin | set | github: 89147 |
| 2021-08-23 22:54:09 | lukasz.langa | set | status: open -> closed resolution: fixed messages: + msg400181 stage: patch review -> resolved |
| 2021-08-23 19:30:26 | miss-islington | set | messages: + msg400171 |
| 2021-08-23 18:48:13 | lukasz.langa | set | messages: + msg400162 |
| 2021-08-23 18:17:37 | lukasz.langa | set | pull_requests: + pull_request26366 |
| 2021-08-23 18:05:18 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request26364 |
| 2021-08-23 18:05:17 | lukasz.langa | set | nosy:
+ lukasz.langa messages: + msg400158 |
| 2021-08-23 14:51:34 | serhiy.storchaka | set | keywords:
+ patch stage: patch review pull_requests: + pull_request26362 |
| 2021-08-23 14:46:11 | serhiy.storchaka | create | |