This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: httplib code thinks it closes connection, but does not
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.1, Python 3.2, Python 2.7
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: orsenthil Nosy List: dstanek, flox, gennad, iritkatriel, jjlee, martin.panter, orsenthil, ysj.ray
Priority: normal Keywords:

Created on 2008-12-02 18:15 by jjlee, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (4)
msg76764 - (view) Author: John J Lee (jjlee) Date: 2008-12-02 18:15
The fix for #900744 tried to close the connection when a bad chunk
length was received.  The comment inserted with that fix "close the
connection as protocol synchronisation is probably lost" is incorrect:
self.close() in _read_chunked does not close the connection.  You have
to call HTTPConnection.close() to close the connection.


 * The comment is incorrect, and should be removed or fixed.  I guess
the self.close() should stay.

 * It's probably a bug that it doesn't result in the connection being
closed.  I guess a fix for that would be for the HTTPResponse to set
some state on itself that HTTPConnection can query so that
HTTPConnection can close itself the next time somebody tries to do
something with the connection.
msg109659 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-07-09 01:24
John could you provide a patch for this?
msg131487 - (view) Author: ysj.ray (ysj.ray) Date: 2011-03-20 12:09
Another fix could be making HTTPResponse to hold a reference to the HTTPConnection object and call its close() at the time of a bad chunk
length was received. This can close the connection as soon as possible.
msg401705 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-09-13 14:51
The code has changed quite a lot since this was created and it no longer matches the description in this issue.
Date User Action Args
2022-04-11 14:56:42adminsetgithub: 48742
2021-09-13 14:51:11iritkatrielsetstatus: open -> closed

nosy: + iritkatriel
messages: + msg401705

resolution: out of date
stage: test needed -> resolved
2014-02-03 15:39:58BreamoreBoysetnosy: - BreamoreBoy
2013-12-28 02:16:57martin.pantersetnosy: + martin.panter
2013-12-17 20:14:02serhiy.storchakasetstage: needs patch -> test needed
2011-03-20 14:40:13orsenthilsetassignee: orsenthil

nosy: + orsenthil
2011-03-20 12:09:24ysj.raysetnosy: jjlee, dstanek, flox, ysj.ray, BreamoreBoy, gennad
messages: + msg131487
2011-03-17 14:58:24ysj.raysetnosy: + ysj.ray
2011-03-17 10:45:31gennadsetnosy: + gennad
2011-03-16 22:19:40floxsetnosy: + flox
2011-01-26 17:54:16dstaneksetnosy: + dstanek
2010-07-09 01:25:00BreamoreBoysetversions: + Python 3.1, Python 3.2, - Python 2.6, Python 3.0
nosy: + BreamoreBoy

messages: + msg109659

stage: needs patch
2008-12-02 18:15:19jjleecreate