This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: base64 RFC4648 test cases
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.11
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: andrei.avk, lukasz.langa, miss-islington
Priority: normal Keywords: patch

Created on 2021-08-09 16:42 by andrei.avk, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 27747 merged andrei.avk, 2021-08-12 20:05
PR 27757 merged miss-islington, 2021-08-13 10:57
Messages (2)
msg399276 - (view) Author: Andrei Kulakov (andrei.avk) * (Python triager) Date: 2021-08-09 16:42
RFC 4648 [1] has added a list of encoding test cases -- see section 10 of the RFC. It might be nice to add a test function that is a direct copy of these test cases. This will make conformance to this RFC clearer (actually right now we don't state conformance with 4648 in the docs except for b32 hex encode/decode, but I'm planning to update the docs in a separate issue).

This will also let us easily keep test cases in sync with future updates in the RFC.

The tests are similar to what we already have except our test cases go from '' => 'abc', and their test cases from '' => 'foobar' (by adding a character at a time in succession). [also some of our test cases go from '' to 'abcde', so a bit inconsistent.]

I've confirmed that all of their test cases pass with Python dev branch code.

I can put up a PR if this sounds good.

msg399525 - (view) Author: Łukasz Langa (lukasz.langa) * (Python committer) Date: 2021-08-13 11:16
Thanks, Andrei! ✨ 🍰 ✨
Date User Action Args
2022-04-11 14:59:48adminsetgithub: 89036
2021-08-13 11:16:06lukasz.langasetstatus: open -> closed

nosy: + lukasz.langa
messages: + msg399525

resolution: fixed
stage: patch review -> resolved
2021-08-13 10:57:49miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request26234
2021-08-12 20:05:13andrei.avksetkeywords: + patch
stage: patch review
pull_requests: + pull_request26225
2021-08-09 16:42:51andrei.avkcreate