classification
Title: Merge tests for typing.Callable and collection.abc.Callable
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.11, Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: gvanrossum, kj, miss-islington, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2021-07-31 12:40 by serhiy.storchaka, last changed 2021-07-31 17:50 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 27507 merged serhiy.storchaka, 2021-07-31 12:42
PR 27514 merged miss-islington, 2021-07-31 17:05
Messages (3)
msg398637 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-07-31 12:40
The proposed PR merges tests for typing.Callable (in test_typing.py) and collection.abc.Callable (in test_genericalias.py). All old tests are now executed for both implementations.

It has exposed a bug in typing.Callable (see issue44793) and minor bug in error message for collection.abc.Callable (missed space). It will help to support consistency of implementations in future.
msg398649 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-07-31 17:06
New changeset be4cb9089aaf58d5f90da5f9fa66dc3c6763b5a2 by Serhiy Storchaka in branch 'main':
bpo-44794: Merge tests for typing.Callable and collection.abc.Callable (GH-27507)
https://github.com/python/cpython/commit/be4cb9089aaf58d5f90da5f9fa66dc3c6763b5a2
msg398651 - (view) Author: miss-islington (miss-islington) Date: 2021-07-31 17:25
New changeset 76903ff9ce2d28f542c44ba97aa043dde8b55daa by Miss Islington (bot) in branch '3.10':
bpo-44794: Merge tests for typing.Callable and collection.abc.Callable (GH-27507)
https://github.com/python/cpython/commit/76903ff9ce2d28f542c44ba97aa043dde8b55daa
History
Date User Action Args
2021-07-31 17:50:01serhiy.storchakasetmessages: - msg398654
2021-07-31 17:49:40serhiy.storchakasetmessages: + msg398654
2021-07-31 17:45:29serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2021-07-31 17:25:30miss-islingtonsetmessages: + msg398651
2021-07-31 17:06:09serhiy.storchakasetmessages: + msg398649
2021-07-31 17:05:54miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request26029
2021-07-31 13:32:02serhiy.storchakalinkissue44796 dependencies
2021-07-31 12:42:10serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request26021
2021-07-31 12:40:30serhiy.storchakacreate