classification
Title: [sqlite3] Use vectorcall in pysqlite_collation_callback
Type: enhancement Stage: resolved
Components: Extension Modules Versions: Python 3.11
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: erlendaasland, pablogsal
Priority: normal Keywords: patch

Created on 2021-07-15 00:48 by erlendaasland, last changed 2021-07-15 21:05 by erlendaasland. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 27158 merged erlendaasland, 2021-07-15 00:50
Messages (2)
msg397521 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-07-15 00:48
pysqlite_collation_callback() currently uses the variable argument function PyObject_CallFunctionObjArgs(). Suggesting micro-optimise this by using PyObject_Vectorcall instead.
msg397562 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2021-07-15 15:49
New changeset 5007a4f23c551f8821483d15e76d0d15d5cb9945 by Erlend Egeberg Aasland in branch 'main':
bpo-44641: Use vectorcall in sqlite3 collation callback (GH-27158)
https://github.com/python/cpython/commit/5007a4f23c551f8821483d15e76d0d15d5cb9945
History
Date User Action Args
2021-07-15 21:05:00erlendaaslandsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2021-07-15 15:49:28pablogsalsetnosy: + pablogsal
messages: + msg397562
2021-07-15 00:50:20erlendaaslandsetkeywords: + patch
stage: patch review
pull_requests: + pull_request25695
2021-07-15 00:48:25erlendaaslandcreate