➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-06-30 08:12 by mohamadmansourx, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 26964 | merged | mohamadmansourx, 2021-06-30 08:51 | |
| Messages (4) | |||
|---|---|---|---|
| msg396771 - (view) | Author: Mohamad Mansour (mohamadmansourx) * | Date: 2021-06-30 08:12 | |
Previous method to check JPG images was using the following command (h[6:10] in (b'JFIF', b'Exif')) However, its not always the case as some might start with b'\xff\xd8\xff\xdb' header. Reference: https://www.digicamsoft.com/itu/itu-t81-36.html https://web.archive.org/web/20120403212223/http://class.ee.iastate.edu/ee528/Reading%20material/JPEG_File_Format.pdf |
|||
| msg397891 - (view) | Author: Łukasz Langa (lukasz.langa) *  |
Date: 2021-07-20 18:13 | |
When JFIF and Exif markers are removed, what we're left with is a "raw" JPEG file. I added a raw equivalent of Lib/test/imghdrdata/python.jpg by running: $ exiftool -all= python.jpg -o python-raw.jpg Mohamad's patch correctly adds support for such files. In fact, browsing through how other languages do this, it seems like the FF D8 FF DB sequence is a relatively popular "magic sequence". It's even listed in this Wikipedia page: https://en.wikipedia.org/wiki/List_of_file_signatures |
|||
| msg397899 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-07-20 18:57 | |
New changeset 3b56b3b97d91e2b412ce1b2bcaddcd43ef3d223b by Mohamad Mansour in branch 'main': bpo-44539: Support recognizing JPEG files without JFIF or Exif markers (GH-26964) https://github.com/python/cpython/commit/3b56b3b97d91e2b412ce1b2bcaddcd43ef3d223b |
|||
| msg397900 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-07-20 18:58 | |
Thanks, Mohamad! ✨ 🍰 ✨ |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:47 | admin | set | github: 88705 |
| 2021-07-20 18:58:16 | lukasz.langa | set | messages: + msg397900 |
| 2021-07-20 18:57:30 | lukasz.langa | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2021-07-20 18:57:04 | lukasz.langa | set | messages: + msg397899 |
| 2021-07-20 18:13:04 | lukasz.langa | set | nosy:
+ lukasz.langa messages: + msg397891 title: Imghdr JPG Quantized -> Support recognizing JPEG files without JFIF or Exif markers |
| 2021-07-09 18:50:26 | eric.araujo | set | versions: - Python 3.6, Python 3.7, Python 3.8, Python 3.9, Python 3.10 |
| 2021-07-03 11:40:38 | fbidu | set | nosy:
+ fbidu |
| 2021-06-30 08:51:23 | mohamadmansourx | set | keywords:
+ patch stage: patch review pull_requests: + pull_request25529 |
| 2021-06-30 08:28:26 | mohamadmansourx | set | components: + Library (Lib), - C API |
| 2021-06-30 08:12:46 | mohamadmansourx | create | |