classification
Title: multi subinterpreters use _PyStructSequence_InitType failed.
Type: crash Stage: patch review
Components: Subinterpreters Versions:
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: JunyiXie
Priority: normal Keywords: patch

Created on 2021-06-29 06:53 by JunyiXie, last changed 2021-06-29 07:04 by JunyiXie.

Pull Requests
URL Status Linked Edit
PR 26949 open JunyiXie, 2021-06-29 07:04
Messages (1)
msg396703 - (view) Author: junyixie (JunyiXie) * Date: 2021-06-29 06:53
In _PyStructSequence_InitType, it will check type is initialized.
but when we have multi subinterpreters, type may be initialized expected.

when type already been initialized, should return 0 rather than throw exception.
```c
/* PyTypeObject has already been initialized */
if (Py_REFCNT(type) != 0) {
    return 0;
}
```


```c
int
_PyStructSequence_InitType(PyTypeObject *type, PyStructSequence_Desc *desc,
                           unsigned long tp_flags)
{
    PyMemberDef *members;
    Py_ssize_t n_members, n_unnamed_members;

#ifdef Py_TRACE_REFS
    /* if the type object was chained, unchain it first
       before overwriting its storage */
    if (type->ob_base.ob_base._ob_next) {
        _Py_ForgetReference((PyObject *)type);
    }
#endif

    /* PyTypeObject has already been initialized */
    if (Py_REFCNT(type) != 0) {
        PyErr_BadInternalCall();
        return -1;
    }
```
History
Date User Action Args
2021-06-29 07:04:58JunyiXiesetkeywords: + patch
stage: patch review
pull_requests: + pull_request25516
2021-06-29 06:53:42JunyiXiecreate