➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-06-26 00:12 by brandtbucher, last changed 2022-04-11 14:59 by admin.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 26922 | merged | brandtbucher, 2021-06-27 00:31 | |
| PR 29357 | merged | brandtbucher, 2021-11-02 00:29 | |
| Messages (2) | |||
|---|---|---|---|
| msg396533 - (view) | Author: Brandt Bucher (brandtbucher) *  |
Date: 2021-06-26 00:11 | |
The generated bytecode for mapping patterns is more complicated than it needs to be: - Matching sub-patterns involves indexing into a tuple of values in order to extract them. We already know the size of this tuple at compile-time, so we can just unpack it onto the stack instead. - COPY_DICT_WITHOUT_KEYS isn't used anywhere else, and can be emulated with existing, smaller instructions (albeit using quite a few of them). - MATCH_KEYS doesn't need to push a boolean indicating match / no match. It already pushes None on no match, so following it with a simple DUP_TOP() + LOAD_CONST(None) + IS_OP(1) should suffice. These are mostly just refactoring opportunities... quick-and-dirty measurements of Lib/test_patma.py show no performance impact for these changes. |
|||
| msg405079 - (view) | Author: Mark Shannon (Mark.Shannon) * |
Date: 2021-10-27 09:45 | |
New changeset 82a662e5216a9b3969054c540a759a9493468510 by Brandt Bucher in branch 'main': bpo-44511: Improve the bytecode for class and mapping patterns (GH-26922) https://github.com/python/cpython/commit/82a662e5216a9b3969054c540a759a9493468510 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:47 | admin | set | github: 88677 |
| 2021-11-02 00:29:19 | brandtbucher | set | pull_requests: + pull_request27617 |
| 2021-10-27 09:45:52 | Mark.Shannon | set | nosy:
+ Mark.Shannon messages: + msg405079 |
| 2021-06-27 00:31:15 | brandtbucher | set | keywords:
+ patch stage: patch review pull_requests: + pull_request25495 |
| 2021-06-26 00:12:00 | brandtbucher | create | |