➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-06-23 09:20 by ssbarnea, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 26873 | closed | ssbarnea, 2021-06-23 10:00 | |
| Messages (2) | |||
|---|---|---|---|
| msg396394 - (view) | Author: Sorin Sbarnea (ssbarnea) * | Date: 2021-06-23 09:20 | |
As the results of investigating a very poor performance of pip while trying to install some code I was able to identify that the root cause was the current implementation of distutils.filelist.findall or to be more precise the _find_all_simple function, which does followsymlinks but without any measures for preventing recursivity and duplicates. To give an idea in my case it was taking 5-10minutes to run while the CPU was at 100%, for a repository with 95k files (most of them temp inside .tox folders). Removal of the symlinks did make it run in ~5s. IMHO, _find_all_simple should normalize paths and avoid returning any duplicates. Realted: https://bugs.launchpad.net/pbr/+bug/1933311 |
|||
| msg396499 - (view) | Author: Dong-hee Na (corona10) *  |
Date: 2021-06-24 16:42 | |
Since the distutils is deprecated at PEP632, I would like to suggest changing the implementation to use setuptools. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:47 | admin | set | github: 88663 |
| 2021-06-24 16:43:21 | corona10 | set | status: open -> closed stage: patch review -> resolved |
| 2021-06-24 16:43:08 | corona10 | set | resolution: wont fix |
| 2021-06-24 16:42:56 | corona10 | set | nosy:
+ corona10 messages: + msg396499 |
| 2021-06-23 10:00:09 | ssbarnea | set | keywords:
+ patch stage: patch review pull_requests: + pull_request25448 |
| 2021-06-23 09:20:53 | ssbarnea | set | type: performance |
| 2021-06-23 09:20:31 | ssbarnea | create | |