classification
Title: PC/frozen_dllmain.c, some expressions have no side effects
Type: behavior Stage:
Components: Versions: Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: brotherbeer
Priority: normal Keywords:

Created on 2021-06-11 08:43 by brotherbeer, last changed 2021-06-11 08:43 by brotherbeer.

Messages (1)
msg395619 - (view) Author: Brother Beer (brotherbeer) Date: 2021-06-11 08:43
cpython-3.10.0b2/PC/frozen_dllmain.c, line 66

 63 void PyWinFreeze_ExeInit(void)
 64 {
 65     char **modName;
 66     for (modName = possibleModules;*modName;*modName++) {
 67 /*              printf("Initialising '%s'\n", *modName); */
 68         CallModuleDllMain(*modName, DLL_PROCESS_ATTACH);
 69     }
 70 }

'*' in '*modName++' is redundant? Line 82 has the same problem

 76 void PyWinFreeze_ExeTerm(void)
 77 {
 78     // Must go backwards
 79     char **modName;
 80     for (modName = possibleModules+Py_ARRAY_LENGTH(possibleModules)-2;
 81          modName >= possibleModules;
 82          *modName--) {
 83 /*              printf("Terminating '%s'\n", *modName);*/
 84         CallModuleDllMain(*modName, DLL_PROCESS_DETACH);
 85     }
 86 }
History
Date User Action Args
2021-06-11 08:43:42brotherbeercreate