classification
Title: [sqlite3] remove unused members from pysqlite_Statement
Type: enhancement Stage: resolved
Components: Extension Modules Versions:
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: erlendaasland Nosy List: erlendaasland, pablogsal
Priority: low Keywords: patch

Created on 2021-06-06 21:27 by erlendaasland, last changed 2021-06-06 22:26 by pablogsal. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 26564 merged erlendaasland, 2021-06-06 21:27
Messages (3)
msg395217 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-06-06 21:28
The db member of pysqlite_Statement is only "used" in the statement create method. Suggesting to remove this. A couple of lines less of code, a couple of bytes less per statement object.
msg395218 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-06-06 21:33
The "sql" member is also unused. Removing this will make the tp_clear method redundant, as there are no PyObjects to clear anymore.
msg395223 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2021-06-06 22:12
New changeset 0d12f245523178eb62e22f5da5a276bfc7004ac4 by Erlend Egeberg Aasland in branch 'main':
bpo-44326: Remove unused members from pysqlite_Statement (GH-26564)
https://github.com/python/cpython/commit/0d12f245523178eb62e22f5da5a276bfc7004ac4
History
Date User Action Args
2021-06-06 22:26:18pablogsalsetstatus: open -> closed
stage: patch review -> resolved
2021-06-06 22:12:19pablogsalsetnosy: + pablogsal
messages: + msg395223
2021-06-06 21:33:08erlendaaslandsetmessages: + msg395218
title: [sqlite3] remove unused db member from pysqlite_Statement -> [sqlite3] remove unused members from pysqlite_Statement
2021-06-06 21:28:37erlendaaslandsetmessages: + msg395217
2021-06-06 21:28:26erlendaaslandset -> (no value)
messages: - msg395216
2021-06-06 21:27:42erlendaaslandsetkeywords: + patch
stage: patch review
pull_requests: + pull_request25153
2021-06-06 21:27:15erlendaaslandcreate