This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: [sqlite3] normalise SQL quoted literals in sqlite3 test suite
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.11
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, corona10, erlendaasland, miss-islington
Priority: low Keywords: easy, patch

Created on 2021-05-11 10:16 by erlendaasland, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 26032 merged erlendaasland, 2021-05-11 10:19
PR 26125 merged miss-islington, 2021-05-14 10:28
PR 26128 merged erlendaasland, 2021-05-14 15:19
Messages (3)
msg393452 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-05-11 10:16
Most of the SQL statements in the sqlite3 test suite correctly uses single quote literals, except test_unicode_content in Lib/sqlite3/test/hooks.py, which uses double quote literals (not ANSI SQL compatible, IIRC). Adapting this test to also use single quote literals makes the sqlite3 test suite compatible with SQLite libraries compiled with SQLITE_DQS=0.


See also:
- https://sqlite.org/compile.html
- https://sqlite.org/quirks.html#dblquote
msg393453 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-05-11 10:39
Digression: test_unicode_content should be named test_trace_unicode_content, in order to express the purpose of the test more clearly, should it fail.
msg393638 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2021-05-14 11:07
New changeset f28bac428d5fff23fe5e95aa02b903ee2dd5b3de by Miss Islington (bot) in branch '3.10':
bpo-44108: sqlite3 test suite now works with SQLITE_DQS=0 (GH-26032) (GH-26125)
https://github.com/python/cpython/commit/f28bac428d5fff23fe5e95aa02b903ee2dd5b3de
History
Date User Action Args
2022-04-11 14:59:45adminsetgithub: 88274
2021-05-14 16:50:18corona10setstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2021-05-14 15:19:07erlendaaslandsetpull_requests: + pull_request24767
2021-05-14 11:07:28corona10setnosy: + corona10
messages: + msg393638
2021-05-14 10:28:53miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request24765
2021-05-11 10:39:36erlendaaslandsetmessages: + msg393453
2021-05-11 10:19:19erlendaaslandsetkeywords: + patch
stage: patch review
pull_requests: + pull_request24680
2021-05-11 10:16:38erlendaaslandcreate