classification
Title: Support SerenityOS Browser in webbrowser module
Type: enhancement Stage: resolved
Components: Library (Lib) Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: gregory.p.smith Nosy List: gregory.p.smith, linusg, miss-islington
Priority: normal Keywords: patch

Created on 2021-05-06 14:44 by linusg, last changed 2021-05-06 23:34 by gregory.p.smith. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 25947 merged linusg, 2021-05-06 15:06
PR 25950 merged miss-islington, 2021-05-06 19:01
Messages (4)
msg393095 - (view) Author: Linus Groh (linusg) * Date: 2021-05-06 14:44
SerenityOS [1] maintains its own port of Python (currently 3.9.5) [2], with increasingly fewer custom patches. It has its own webbrowser (called "Browser") [3][4], which is the only browser installed by default - as a result, webbrowser.open() currently does not work out of the box. However, register()'ing the browser was straightforward [5]. The goal of this issue is to get that patch into upstream Python.


[1] github.com/SerenityOS/serenity
[2] https://github.com/SerenityOS/serenity/blob/master/Ports/python3
[3] https://github.com/SerenityOS/serenity/tree/master/Userland/Applications/Browser
[4] https://github.com/SerenityOS/serenity/blob/master/Documentation/Browser/ProcessArchitecture.md
[5] https://github.com/SerenityOS/serenity/commit/9f970c3459be761c6d1ac192eb494d630b4ca1ed
msg393131 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2021-05-06 18:44
Quite a humorous long list of historical browsers still in the webbrowser module.  This can join the list.  The PR should automerge after the CI runs complete.
msg393141 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2021-05-06 19:49
New changeset fbefdaf92e40134c43142c182f7c5bfe406e4c2b by Miss Islington (bot) in branch '3.10':
bpo-44059: Register the SerenityOS Browser in the webbrowser module (GH-25947) (GH-25950)
https://github.com/python/cpython/commit/fbefdaf92e40134c43142c182f7c5bfe406e4c2b
msg393155 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2021-05-06 23:34
thanks for the PR!
History
Date User Action Args
2021-05-06 23:34:37gregory.p.smithsetstatus: open -> closed
resolution: fixed
messages: + msg393155

stage: patch review -> resolved
2021-05-06 19:49:29gregory.p.smithsetmessages: + msg393141
2021-05-06 19:01:28miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request24613
2021-05-06 18:44:27gregory.p.smithsetassignee: gregory.p.smith

messages: + msg393131
nosy: + gregory.p.smith
2021-05-06 15:06:09linusgsetkeywords: + patch
stage: patch review
pull_requests: + pull_request24611
2021-05-06 14:44:55linusgcreate