Just noticed the following code in urrlib.parse_qsl:

    pairs = [s1 for s1 in qs.split(separator)]
    for name_value in pairs:
        ...

see https://github.com/python/cpython/blob/088a15c49d99ecb4c3bef93f8f40dd513c6cae3b/Lib/urllib/parse.py#L755

This looks like an unnecessary list comprehension to me, probably a relic of earlier code that used a nested list comprehension for splitting with two different separators.

Can't we just do this instead now, which is faster and shorter?

   for name_value qs.split(separator):

I can provide a PR if wanted.

Seems like a nice simplification to me. Can I open PR? :)

> I can provide a PR if wanted.

Please submit the PR if you want

I saw you submitted a PR already which looks good to me.

> I saw you submitted a PR already which looks good to me.

I should care that you can have a chance to submit the patch :)
Is it okay to proceed with this issue with the PR which I closed or do you want to open a PR with your hand?

I don't mind if you reopen your PR. But thanks for asking.

> I don't mind if you reopen your PR. But thanks for asking.

I add your name as the co-author on PR 25756 :)
Thanks for the report and suggestion

New changeset 6143fcdf8bfe54c24e3081bcee423f4d51f35c4e by Dong-hee Na in branch 'master':
bpo-43979: Remove unnecessary operation from urllib.parse.parse_qsl (GH-25756)
https://github.com/python/cpython/commit/6143fcdf8bfe54c24e3081bcee423f4d51f35c4e