This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Possible missing word on unittest doc
Type: Stage: resolved
Components: Documentation Versions: Python 3.11, Python 3.10, Python 3.9, Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: ZackerySpytz, docs@python, mdk, methane, miss-islington, rhettinger
Priority: normal Keywords: patch

Created on 2021-04-27 12:21 by mdk, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 25672 merged ZackerySpytz, 2021-04-27 22:14
PR 25741 merged miss-islington, 2021-04-30 07:35
Messages (8)
msg392060 - (view) Author: Julien Palard (mdk) * (Python committer) Date: 2021-04-27 12:21
In https://docs.python.org/3/library/unittest.html I see:

> Note that you need to the top level directory too.

Trying to guess, the missing word may be "specify":

> Changed in version 3.4: Test discovery supports namespace packages for start directory. Note that you need to specify the top level directory too. (e.g. python -m unittest discover -s root/namespace -t root).

Am I right?
msg392091 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2021-04-27 15:50
Yes, "specify" is likely the missing word.
msg392143 - (view) Author: Inada Naoki (methane) * (Python committer) Date: 2021-04-27 22:18
namespace package support is broken since Python 3.7.
See https://bugs.python.org/issue23882#msg387549

We can not use namespace package even if top level directory is specified.
msg392172 - (view) Author: Inada Naoki (methane) * (Python committer) Date: 2021-04-28 08:17
I propose to remove the namespace package support entirely.

* No user (since it has been broken from Python 3.7)
* Hard to maintain (we haven't noted it)
* Hard to explain (need to specify the top directory. don't search recursively. See bpo-23882)
msg392213 - (view) Author: Julien Palard (mdk) * (Python committer) Date: 2021-04-28 15:15
> I propose to remove the namespace package support entirely.

I'm no unittest expert, but I have nothing against removing it.

I totally agree to at least remove it from the doc while it does not work.
msg392386 - (view) Author: Julien Palard (mdk) * (Python committer) Date: 2021-04-30 07:32
New changeset 2abbd8f2add5e80b86a965625b9a77ae94a101cd by Zackery Spytz in branch 'master':
bpo-43954: Fix a missing word in the unittest docs (GH-25672)
https://github.com/python/cpython/commit/2abbd8f2add5e80b86a965625b9a77ae94a101cd
msg392387 - (view) Author: Julien Palard (mdk) * (Python committer) Date: 2021-04-30 07:36
As far as this issue is concerned, it's fixed.

The discussion about this feature not working can continue in the appropriate issue (23882)
msg392388 - (view) Author: miss-islington (miss-islington) Date: 2021-04-30 07:57
New changeset a92d7387632de1fc64de51f22f6191acd0c6f5c0 by Miss Islington (bot) in branch '3.9':
bpo-43954: Fix a missing word in the unittest docs (GH-25672)
https://github.com/python/cpython/commit/a92d7387632de1fc64de51f22f6191acd0c6f5c0
History
Date User Action Args
2022-04-11 14:59:44adminsetgithub: 88120
2021-04-30 07:57:03miss-islingtonsetmessages: + msg392388
2021-04-30 07:36:15mdksetstatus: open -> closed
resolution: fixed
messages: + msg392387

stage: patch review -> resolved
2021-04-30 07:35:08miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request24431
2021-04-30 07:32:43mdksetmessages: + msg392386
2021-04-28 22:22:58larrysetnosy: - larry
2021-04-28 15:43:11rhettingersetnosy: + larry
2021-04-28 15:15:31mdksetmessages: + msg392213
2021-04-28 08:17:45methanesetmessages: + msg392172
2021-04-27 22:18:43methanesetmessages: + msg392143
2021-04-27 22:14:14ZackerySpytzsetkeywords: + patch
nosy: + ZackerySpytz

pull_requests: + pull_request24363
stage: patch review
2021-04-27 15:50:19rhettingersetnosy: + rhettinger
messages: + msg392091
2021-04-27 12:21:08mdkcreate