This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: IDLE editor file minor refactoring
Type: Stage: patch review
Components: IDLE Versions: Python 3.10, Python 3.9, Python 3.8
Status: open Resolution:
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: epaine, eric.araujo, terry.reedy
Priority: normal Keywords: patch

Created on 2021-04-20 16:15 by epaine, last changed 2022-04-11 14:59 by admin.

Pull Requests
URL Status Linked Edit
PR 25485 closed epaine, 2021-04-20 16:16
Messages (4)
msg391449 - (view) Author: E. Paine (epaine) * Date: 2021-04-20 16:15
Despite being large, the PR is mostly trivial changes (e.g. changing indentation). The main changes worth noting (and hence the reason for this issue) are:
1) the renaming of `ResetColorizer` to `reset_colors`, `ResetFont` to `reset_font`, `RemoveKeybindings` to `remove_keybindings` and `ApplyKeybindings` to `apply_keybindings`.
2) removal of some potentially unneeded imports
3) renaming of the `tokeneater` args to be lowercase

I chose `reset_colors` (as proposed in PR-22682) rather than `reset_colorizer` because we are reconfiguring the Text, code context and line numbers, rather than only dealing with the colouriser.
msg391727 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2021-04-23 19:04
Hello and thanks for wanting to contribute to Python!

In the CPython project, stylistic changes are not made by themselves as a matter of course (accross the whole codebase or in a specific module): among reasons, these obfuscate file history, need reviewer time that takes away from other changes, and can introduce subtle bugs.  Or in short: if it’s not broken, don’t fix it!

This is different from other projects, especially those that have a smaller codebase, much less history than Python, and can agree on using some automated tool for trivial formatting changes.

So if the changes here are not motivated by a bugfix or a new features, I think they should not be accepted.
msg391735 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2021-04-23 21:18
This started as an extraction and revision of changes in Tal's PR, one of which appeared to be an intended behavior change, that I requested there.  Paine may have expanded the scope more than I intended.  Will look soon.
msg391736 - (view) Author: E. Paine (epaine) * Date: 2021-04-23 21:23
I agree with your points and understand that there is good reason for the PR to be rejected. If Terry decides it's too big (I did do a lot more than what was originally in PR-22682), I am more than happy to close this issue.
Date User Action Args
2022-04-11 14:59:44adminsetgithub: 88060
2021-04-23 21:23:39epainesetmessages: + msg391736
2021-04-23 21:18:45terry.reedysetmessages: + msg391735
2021-04-23 19:04:17eric.araujosetnosy: + eric.araujo
messages: + msg391727
2021-04-20 16:16:03epainesetkeywords: + patch
stage: patch review
pull_requests: + pull_request24211
2021-04-20 16:15:23epainecreate