This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: GitHub Actions CI/CD `Coverage` job is broken on master
Type: Stage: resolved
Components: Versions:
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: BTaskaya, ammar2, brett.cannon, miss-islington, pablogsal, webknjaz
Priority: normal Keywords: patch

Created on 2021-04-19 11:50 by webknjaz, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 25471 merged webknjaz, 2021-04-19 12:06
PR 25679 merged ammar2, 2021-04-28 05:07
Messages (7)
msg391373 - (view) Author: Sviatoslav Sydorenko (webknjaz) * Date: 2021-04-19 11:50
I noticed that (a coverage job on the last commit on master at the time of writing) takes suspiciously long to complete.

I did some investigation and noticed that this job on the 3.9 branch succeeds (all of the job runs on the first page in the list are green —

But then I took a look at the runs on master and discovered that the last successful run was 4 months ago —

The last success is and after that, starting with, if fails consistently.

Notably, all of the failures are caused by the job timeout after *6 hours* — GitHub platform just kills those, 6h is a default per-job timeout in GHA.

It's also important to mention that before every job starting timing out effectively burning 6 hours of GHA time for each merge and producing no useful reports, there were occasional 6h-timeouts but they weren't consistent.

Looking into the successful runs from the past, on master and other jobs, I haven't noticed it taking more than 1h35m to complete with a successful outcome. Taking into account this as a baseline, I suggest changing the timeout of the whole job or maybe just one step that actually runs coverage.

Action items:
* Set job timeout in GHA to 1h40m (allowing a bit of extra time for exceptionally slow jobs) — this will make sure that the failure/timeout is reported sooner than 6h
* Figure out why this started happening in the first place.

I'm going to send a PR addressing the first point but feel free to pick up the investigation part — I don't expect to have time for this anytime soon.

P.S. FTR the last timeout of this type happened two months ago —
msg391412 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2021-04-19 22:44
It might be time to just kill the coverage report since people are obviously not looking at the results.
msg391455 - (view) Author: miss-islington (miss-islington) Date: 2021-04-20 17:22
New changeset 077a2e76649c2fc49ebb8982b6855bab09a85e8f by Sviatoslav Sydorenko in branch 'master':
bpo-43888: Reduce coverage collection timeout to 1h40m in GHA (GH-25471)
msg391836 - (view) Author: Batuhan Taskaya (BTaskaya) * (Python committer) Date: 2021-04-25 04:33
Coverage runs are still failing on the master, and I think at least we should do something like allow failure or other wise github will send notifications for this flaky run.
msg391837 - (view) Author: Ammar Askar (ammar2) * (Python committer) Date: 2021-04-25 04:36
For what it's worth I think Brett's suggestion of just removing the coverage build entirely is good too since it seems like no one actually looks at the results and they take up valuable CI time.
msg392514 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2021-04-30 21:04
New changeset 726c931b3896dc73fd156e2340b5ef0b8f55cfb7 by Ammar Askar in branch 'master':
bpo-43888: Remove coverage builds from CI (GH-25679)
msg392527 - (view) Author: Ammar Askar (ammar2) * (Python committer) Date: 2021-04-30 22:41
Coverage builds have been removed from the CI, closing this now.
Date User Action Args
2022-04-11 14:59:44adminsetgithub: 88054
2021-04-30 22:41:40ammar2setstatus: open -> closed
resolution: fixed
messages: + msg392527

stage: patch review -> resolved
2021-04-30 21:04:47brett.cannonsetmessages: + msg392514
2021-04-28 05:07:12ammar2setpull_requests: + pull_request24370
2021-04-25 04:36:37ammar2setnosy: + ammar2
messages: + msg391837
2021-04-25 04:33:19BTaskayasetnosy: + BTaskaya
messages: + msg391836
2021-04-20 17:22:30miss-islingtonsetnosy: + miss-islington
messages: + msg391455
2021-04-19 22:44:11brett.cannonsetmessages: + msg391412
2021-04-19 19:46:02ned.deilysetnosy: + brett.cannon, pablogsal
2021-04-19 12:06:18webknjazsetkeywords: + patch
stage: patch review
pull_requests: + pull_request24196
2021-04-19 11:51:07webknjazsettype: crash ->
2021-04-19 11:50:46webknjazcreate