➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-03-29 07:07 by terry.reedy, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 25170 | merged | terry.reedy, 2021-04-03 22:58 | |
| PR 29397 | merged | steve.dower, 2021-11-04 00:43 | |
| PR 29407 | merged | steve.dower, 2021-11-04 16:44 | |
| Messages (12) | |||
|---|---|---|---|
| msg389662 - (view) | Author: Terry J. Reedy (terry.reedy) *  |
Date: 2021-03-29 07:07 | |
#39017, PR 22405 was too late for 3.9, but the new Mac installer is already using 8.6.11. Serhiy, do you know any reason not to upgrade the Windows installer to 8.6.11 also? Steve, should a new PR with '10' replaced with '11, where '9' was replaced with '10' before, be sufficient? I presumt the 'v14' for VC13 should be left alone. To test, would 8.6.11 be built on my system, or is it fetched externally? |
|||
| msg389774 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2021-03-29 23:45 | |
I also need to pull the Tcl and Tk sources into our cpython-source-deps repository, run a signed build, and put the binaries into the cpython-bin-deps repository. I'll get that started tonight, but probably won't finish it until tomorrow. |
|||
| msg389776 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2021-03-30 00:08 | |
Turns out I did get it done, so you should be able to update the references you find in the PCbuild directory and get a build. |
|||
| msg390147 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2021-04-03 22:48 | |
Did you use revision 0, and in 8.6.11.0, or a later one? As I mentioned in #43719, I cannot currently build master, but I will upload a PR (with .0) for CI to test. |
|||
| msg390148 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2021-04-03 23:04 | |
The upgrade to 8.6.10 broke a Scale test. The fix for that in #41306 conv = False if get_tk_patchlevel() >= (8, 6, 10) else float_round should still work unless there was a further Scale change. |
|||
| msg391741 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2021-04-23 21:41 | |
Thanks for finishing up that patch. And yes, we add a ".0" in case we need to patch the sources ourselves. |
|||
| msg391749 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2021-04-23 22:45 | |
Previous issue, which I mistyped, was #39107. Release notes at https://sourceforge.net/projects/tcl/files/Tcl/8.6.11/tcltk-release-notes-8.6.11.txt/view |
|||
| msg405455 - (view) | Author: E. Paine (epaine) * | Date: 2021-11-01 17:17 | |
This does not seem to have done the trick. The installers for 3.10.0 and 3.11.0a1 both use Tk 8.6.10 still. This can be verified using the bug in #45681 or using `tkinter.test.support.get_tk_patchlevel()`. |
|||
| msg405470 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2021-11-01 21:18 | |
Looks like something went wrong back when I built it in March and it built the older version again. I probably need to revamp that build step. I think it relies on a race to build properly, since it's in the main repo. We need a way to override the version it's going to build without modifying the repo, since we can't modify the repo without the build being done. |
|||
| msg405735 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2021-11-04 16:39 | |
New changeset 36b4f9e2a7d5ed55c441eb6dfe5c13baa483b9d4 by Steve Dower in branch 'main': bpo-43652: Actually update to Tcl/Tk 8.6.11 on Windows (GH-29397) https://github.com/python/cpython/commit/36b4f9e2a7d5ed55c441eb6dfe5c13baa483b9d4 |
|||
| msg405740 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2021-11-04 17:28 | |
New changeset 6340ba7f2c1bef94939dcab0d5babc256ffd7485 by Steve Dower in branch '3.10': bpo-43652: Actually update to Tcl/Tk 8.6.11 on Windows (GH-29397) https://github.com/python/cpython/commit/6340ba7f2c1bef94939dcab0d5babc256ffd7485 |
|||
| msg405747 - (view) | Author: Terry J. Reedy (terry.reedy) * |
Date: 2021-11-04 19:35 | |
This worked for me on main and 3.10. Thanks. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:43 | admin | set | github: 87818 |
| 2021-11-04 19:35:01 | terry.reedy | set | messages: + msg405747 |
| 2021-11-04 17:28:05 | steve.dower | set | messages: + msg405740 |
| 2021-11-04 16:44:39 | steve.dower | set | pull_requests: + pull_request27663 |
| 2021-11-04 16:39:25 | steve.dower | set | messages: + msg405735 |
| 2021-11-04 00:43:25 | steve.dower | set | pull_requests: + pull_request27655 |
| 2021-11-01 21:18:40 | steve.dower | set | messages: + msg405470 |
| 2021-11-01 17:17:30 | epaine | set | nosy:
+ epaine messages: + msg405455 |
| 2021-04-23 22:45:27 | terry.reedy | set | messages: + msg391749 |
| 2021-04-23 21:41:34 | steve.dower | set | status: open -> closed resolution: fixed messages: + msg391741 stage: needs patch -> resolved |
| 2021-04-03 23:04:53 | terry.reedy | set | messages:
+ msg390148 stage: patch review -> needs patch |
| 2021-04-03 22:58:51 | terry.reedy | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request23911 |
| 2021-04-03 22:48:43 | terry.reedy | set | messages: + msg390147 |
| 2021-03-30 00:08:11 | steve.dower | set | messages: + msg389776 |
| 2021-03-29 23:45:00 | steve.dower | set | messages: + msg389774 |
| 2021-03-29 07:07:11 | terry.reedy | create | |