classification
Title: distutils.command.register is broken
Type: behavior Stage: commit review
Components: Distutils Versions: Python 3.0
process
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: barry Nosy List: amaury.forgeotdarc, barry, christian.heimes, hagen, loewis
Priority: release blocker Keywords: patch

Created on 2008-11-19 16:11 by hagen, last changed 2008-11-20 16:26 by loewis. This issue is now closed.

Files
File name Uploaded Description Edit
distutils_register.patch hagen, 2008-11-19 16:11
distutils_register_2.patch hagen, 2008-11-19 17:39
Messages (5)
msg76055 - (view) Author: Hagen Fürstenau (hagen) Date: 2008-11-19 16:11
The distutils command "register" has two problems with Python 3.0:

1. The authentication dialog crashes because of a problem with the
functiopn raw_input defined there.

2. Uploading the data fails because of str/bytes confusion.

The attached patch addresses both problems.
msg76058 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2008-11-19 16:59
The patch looks good to me.
You can however remove the "import sys": it is not needed.
msg76061 - (view) Author: Hagen Fürstenau (hagen) Date: 2008-11-19 17:39
Attached new patch without "sys".
msg76106 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2008-11-20 14:25
The patch is fine with me.
msg76116 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2008-11-20 16:26
Thanks for the patch. Committed as r67298.

For some reason, the saved credentials won't be read back in. Not sure
whether this is specific to 3.0, though, or part of the new PyPIRC handling.
History
Date User Action Args
2008-11-20 16:26:21loewissetstatus: open -> closed
messages: + msg76116
2008-11-20 14:25:54christian.heimessetnosy: + barry, christian.heimes
messages: + msg76106
priority: release blocker
assignee: barry
resolution: accepted
stage: commit review
2008-11-19 19:19:31loewissetnosy: + loewis
2008-11-19 17:39:30hagensetfiles: + distutils_register_2.patch
messages: + msg76061
2008-11-19 16:59:58amaury.forgeotdarcsetnosy: + amaury.forgeotdarc
messages: + msg76058
2008-11-19 16:11:58hagencreate