classification
Title: Dead assignment in idna_converter function
Type: enhancement Stage: patch review
Components: Library (Lib) Versions: Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: alex.henrie
Priority: normal Keywords: patch

Created on 2021-03-02 02:29 by alex.henrie, last changed 2021-03-02 02:31 by alex.henrie.

Pull Requests
URL Status Linked Edit
PR 24701 open alex.henrie, 2021-03-02 02:31
Messages (1)
msg387896 - (view) Author: Alex Henrie (alex.henrie) * Date: 2021-03-02 02:29
The idna_converter function in socketmodule.c currently initializes the variable len to -1, then reinitializes it on every path that uses it. The first initialization could be removed to simplify the code and clarify its intent.

Defect identified by scan-build <https://clang-analyzer.llvm.org/scan-build.html>
History
Date User Action Args
2021-03-02 02:31:03alex.henriesetkeywords: + patch
stage: patch review
pull_requests: + pull_request23478
2021-03-02 02:29:09alex.henriecreate