classification
Title: Dead initialization in parse_abbr function
Type: enhancement Stage: patch review
Components: Library (Lib) Versions: Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: alex.henrie
Priority: normal Keywords: patch

Created on 2021-03-02 02:25 by alex.henrie, last changed 2021-03-02 02:26 by alex.henrie.

Pull Requests
URL Status Linked Edit
PR 24700 open alex.henrie, 2021-03-02 02:26
Messages (1)
msg387895 - (view) Author: Alex Henrie (alex.henrie) * Date: 2021-03-02 02:25
The parse_abbr function in _zoneinfo.c currently initializes the variable buff regardless of whether it is going to be used, and then initializes it again in the one path that does use it. The first initialization could be removed to simplify the code and clarify its intent.

Defect identified by scan-build <https://clang-analyzer.llvm.org/scan-build.html>
History
Date User Action Args
2021-03-02 02:26:22alex.henriesetkeywords: + patch
stage: patch review
pull_requests: + pull_request23477
2021-03-02 02:25:12alex.henriecreate