classification
Title: [sqlite3] remove pre SQLite 3.7.7 support code
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, erlendaasland, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2021-02-24 10:48 by erlendaasland, last changed 2021-02-26 00:48 by berker.peksag. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 24637 merged erlendaasland, 2021-02-24 10:54
Messages (2)
msg387616 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-02-24 10:48
I missed the SQLITE_OPEN_URI #ifdef in GH-24106. The "open URI" interface was added in 3.7.7. The dead code can safely be removed.

$ grep -r SQLITE_OPEN_URI sqlite-3.7.6/
$ grep -r SQLITE_OPEN_URI sqlite-3.7.7/
[...]
sqlite-3.7.7/sqlite3.h:#define SQLITE_OPEN_URI              0x00000040  /* Ok for sqlite3_open_v2() */
msg387697 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2021-02-26 00:48
New changeset 3150754f91fc1d15e3888e22c065672838a9c069 by Erlend Egeberg Aasland in branch 'master':
bpo-43314: Remove SQLITE_OPEN_URI ifdef (GH-24637)
https://github.com/python/cpython/commit/3150754f91fc1d15e3888e22c065672838a9c069
History
Date User Action Args
2021-02-26 00:48:55berker.peksagsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2021-02-26 00:48:26berker.peksagsetmessages: + msg387697
2021-02-24 10:54:30erlendaaslandsetkeywords: + patch
stage: patch review
pull_requests: + pull_request23422
2021-02-24 10:48:54erlendaaslandcreate