➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-02-19 12:05 by erlendaasland, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 24578 | merged | erlendaasland, 2021-02-19 12:12 | |
| PR 24605 | merged | erlendaasland, 2021-02-21 06:51 | |
| Messages (5) | |||
|---|---|---|---|
| msg387310 - (view) | Author: Erlend E. Aasland (erlendaasland) *  |
Date: 2021-02-19 12:05 | |
There's a lot of file scoped functions without the static storage-class specifier. All file local functions should have the static storage-class specifier. |
|||
| msg387314 - (view) | Author: Erlend E. Aasland (erlendaasland) * |
Date: 2021-02-19 12:32 | |
Ref. https://github.com/python/cpython/pull/24569#issuecomment-782014177, Berker. |
|||
| msg387432 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2021-02-21 00:29 | |
New changeset bf838a6e7eec2063a17c7c33dfa94afeef116f36 by Erlend Egeberg Aasland in branch 'master': bpo-43269: Clean up sqlite3 file scope (GH-24578) https://github.com/python/cpython/commit/bf838a6e7eec2063a17c7c33dfa94afeef116f36 |
|||
| msg387441 - (view) | Author: Erlend E. Aasland (erlendaasland) * |
Date: 2021-02-21 06:51 | |
Serhiy also mentioned that marking functions definitions with the extern keyword is not very common in the CPython source base. https://github.com/python/cpython/pull/24578#discussion_r579506678 I suggest cleaning up those as well, while we're at it. |
|||
| msg387449 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2021-02-21 10:07 | |
New changeset 38b6c2acd4bba666bd64779c42b9d91cbee19274 by Erlend Egeberg Aasland in branch 'master': bpo-43269: Remove redundant extern keywords (GH-24605) https://github.com/python/cpython/commit/38b6c2acd4bba666bd64779c42b9d91cbee19274 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:41 | admin | set | github: 87435 |
| 2021-02-21 10:08:29 | berker.peksag | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2021-02-21 10:07:52 | berker.peksag | set | messages: + msg387449 |
| 2021-02-21 06:51:54 | erlendaasland | set | pull_requests: + pull_request23383 |
| 2021-02-21 06:51:00 | erlendaasland | set | messages: + msg387441 |
| 2021-02-21 00:29:33 | berker.peksag | set | messages: + msg387432 |
| 2021-02-19 12:32:17 | erlendaasland | set | messages: + msg387314 |
| 2021-02-19 12:12:14 | erlendaasland | set | keywords:
+ patch stage: patch review pull_requests: + pull_request23357 |
| 2021-02-19 12:05:57 | erlendaasland | create | |