classification
Title: Port curses capi pointer array to a struct
Type: enhancement Stage: patch review
Components: Versions: Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: shihai1991 Nosy List: erlendaasland, shihai1991, vstinner
Priority: normal Keywords: patch

Created on 2021-01-23 12:33 by shihai1991, last changed 2021-01-29 09:52 by erlendaasland.

Pull Requests
URL Status Linked Edit
PR 24304 open shihai1991, 2021-01-23 12:36
Messages (6)
msg385532 - (view) Author: hai shi (shihai1991) * (Python triager) Date: 2021-01-23 12:33
As the title mentioned. A entire py_curses capi struct would be better than pointer array.

Related PR: PR 24186
msg385881 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-01-28 20:25
The _decimal API is also just an array of pointers. Should we change that to a struct as well?
msg385899 - (view) Author: hai shi (shihai1991) * (Python triager) Date: 2021-01-29 09:33
> The _decimal API is also just an array of pointers. Should we change that to a struct as well?

+1. IMHO, structure is more directly than pointer array. And there haven't exposing this pointer array to users(no backward compatibility).
msg385900 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-01-29 09:43
> +1. IMHO, structure is more directly than pointer array. And there haven't exposing this pointer array to users(no backward compatibility).

Good. I'll open a separate issue and give it a try. Thanks!
msg385902 - (view) Author: hai shi (shihai1991) * (Python triager) Date: 2021-01-29 09:47
> The _decimal API is also just an array of pointers. Should we change that to a struct as well?

Hi, victor. Do you have suggestion about it :)
msg385903 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-01-29 09:52
FYI: I've opened bpo-43060 for the decimal module.
History
Date User Action Args
2021-01-29 09:52:57erlendaaslandsetmessages: + msg385903
2021-01-29 09:47:28shihai1991setmessages: + msg385902
2021-01-29 09:43:52erlendaaslandsetmessages: + msg385900
2021-01-29 09:33:58shihai1991setmessages: + msg385899
2021-01-28 20:25:48erlendaaslandsetnosy: + erlendaasland
messages: + msg385881
2021-01-23 12:36:43shihai1991setkeywords: + patch
stage: patch review
pull_requests: + pull_request23125
2021-01-23 12:33:41shihai1991create