➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2020-12-27 08:11 by corona10, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 23965 | merged | erlendaasland, 2020-12-27 10:18 | |
| PR 23970 | merged | miss-islington, 2020-12-27 22:35 | |
| PR 23971 | merged | miss-islington, 2020-12-27 22:35 | |
| Messages (4) | |||
|---|---|---|---|
| msg383838 - (view) | Author: Dong-hee Na (corona10) *  |
Date: 2020-12-27 08:11 | |
Docs says that pages default value is 0 but the implementation is -1 docs: https://docs.python.org/3/library/sqlite3.html#sqlite3.Connection.backup impl: https://github.com/python/cpython/blob/f4507231e3f0cf8827cec5592571ce371c6813e8/Modules/_sqlite/connection.c#L1565 But the behavior will be the same and if the pages is set to zero, we update this value to -1. https://github.com/python/cpython/blob/f4507231e3f0cf8827cec5592571ce371c6813e8/Modules/_sqlite/connection.c#L1625 So IMHO, I'd like to suggest updating the docs rather than updating the implementation. |
|||
| msg383871 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2020-12-27 22:35 | |
New changeset abba83b4b91f78dc556dc0b7700ecb46cba22c01 by Erlend Egeberg Aasland in branch 'master': bpo-42755: Fix sqlite3.Connection.backup docs (GH-23965) https://github.com/python/cpython/commit/abba83b4b91f78dc556dc0b7700ecb46cba22c01 |
|||
| msg383874 - (view) | Author: miss-islington (miss-islington) | Date: 2020-12-27 22:56 | |
New changeset 9f6a37cc072dab9f9a13d491d3592d23d9809d2b by Miss Islington (bot) in branch '3.9': bpo-42755: Fix sqlite3.Connection.backup docs (GH-23965) https://github.com/python/cpython/commit/9f6a37cc072dab9f9a13d491d3592d23d9809d2b |
|||
| msg384455 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2021-01-06 00:23 | |
New changeset 28611c28474a7fafdcf7ea2712f2670dda940eef by Miss Islington (bot) in branch '3.8': bpo-42755: Fix sqlite3.Connection.backup docs (GH-23965) https://github.com/python/cpython/commit/28611c28474a7fafdcf7ea2712f2670dda940eef |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:39 | admin | set | github: 86921 |
| 2021-01-06 00:23:46 | berker.peksag | set | messages: + msg384455 |
| 2020-12-27 22:56:44 | miss-islington | set | nosy:
+ miss-islington messages: + msg383874 |
| 2020-12-27 22:36:19 | pablogsal | set | status: open -> closed nosy: - miss-islington resolution: fixed stage: patch review -> resolved |
| 2020-12-27 22:35:57 | miss-islington | set | pull_requests: + pull_request22816 |
| 2020-12-27 22:35:49 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request22815 |
| 2020-12-27 22:35:33 | pablogsal | set | nosy:
+ pablogsal messages: + msg383871 |
| 2020-12-27 10:18:04 | erlendaasland | set | keywords:
+ patch stage: patch review pull_requests: + pull_request22810 |
| 2020-12-27 08:11:58 | corona10 | create | |