This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_tcl failed on 32-bit POWER6 AIX 3.9: big int issue with 9223372036854775808
Type: Stage: resolved
Components: Tests, Tkinter Versions: Python 3.10, Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: David.Edelsohn, Michael.Felt, gpolo, miss-islington, serhiy.storchaka, vstinner
Priority: normal Keywords: patch

Created on 2020-12-26 11:11 by vstinner, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 23955 merged serhiy.storchaka, 2020-12-26 12:12
PR 23961 merged miss-islington, 2020-12-27 08:13
PR 23962 merged miss-islington, 2020-12-27 08:13
PR 23966 merged serhiy.storchaka, 2020-12-27 13:32
PR 23989 merged miss-islington, 2020-12-29 10:56
PR 23990 merged miss-islington, 2020-12-29 10:56
Messages (12)
msg383802 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-12-26 11:11
POWER6 AIX 3.9:
https://buildbot.python.org/all/#/builders/330/builds/221

test.pythoninfo:

platform.architecture: 32bit
platform.platform: AIX-2-00F9C1964C00-powerpc-32bit
tkinter.TCL_VERSION: 8.4
tkinter.TK_VERSION: 8.4
tkinter.info_patchlevel: 8.5.9

======================================================================
FAIL: test_expr_bignum (test.test_tcl.TclTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/aixtools/buildarea/3.9.aixtools-aix-power6/build/Lib/test/test_tcl.py", line 441, in test_expr_bignum
    self.assertEqual(result, i)
AssertionError: <bignum object: '9223372036854775808'> != 9223372036854775808

======================================================================
FAIL: test_getint (test.test_tcl.TclTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/aixtools/buildarea/3.9.aixtools-aix-power6/build/Lib/test/test_tcl.py", line 148, in test_getint
    self.assertEqual(tcl.getint(' %d ' % i), i)
AssertionError: -9223372036854775808 != 9223372036854775808

======================================================================
FAIL: test_passing_values (test.test_tcl.TclTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/aixtools/buildarea/3.9.aixtools-aix-power6/build/Lib/test/test_tcl.py", line 475, in test_passing_values
    self.assertEqual(passValue(i), i if self.wantobjects else str(i))
AssertionError: '9223372036854775808' != 9223372036854775808

----------------------------------------------------------------------
msg383803 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-12-26 11:47
Interesting that static version is 8.4, but pathlevel is 8.5.9. It means that Tkinter is built with older version of headers and does not support bignum type, but dynamically linked to newer library which can create bignum objects.

There is a problem with tests. They should be skipped if Tkinter is built with old Tcl headers (it is not easy to do reliable). But there is also a problem with configuration which founds too old headers.
msg383839 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-12-27 08:13
New changeset b02ad2458bc127a7afdeef414fa68c9a7f1f32af by Serhiy Storchaka in branch 'master':
bpo-42749: Fix testing bignum if Tkinter is compiled with Tk 8.4 and dynamic linked with Tk >= 8.5 (GH-23955)
https://github.com/python/cpython/commit/b02ad2458bc127a7afdeef414fa68c9a7f1f32af
msg383840 - (view) Author: miss-islington (miss-islington) Date: 2020-12-27 08:32
New changeset dda12ad63e927e93d71462ad77cc84da55bada9b by Miss Islington (bot) in branch '3.9':
bpo-42749: Fix testing bignum if Tkinter is compiled with Tk 8.4 and dynamic linked with Tk >= 8.5 (GH-23955)
https://github.com/python/cpython/commit/dda12ad63e927e93d71462ad77cc84da55bada9b
msg383842 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-12-27 08:56
New changeset 9d7c5ab6a4ae9d69b39bd16c3195bf6405ddc2d1 by Miss Islington (bot) in branch '3.8':
bpo-42749: Fix testing bignum if Tkinter is compiled with Tk 8.4 and dynamic linked with Tk >= 8.5 (GH-23955) (GH-23962)
https://github.com/python/cpython/commit/9d7c5ab6a4ae9d69b39bd16c3195bf6405ddc2d1
msg383843 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-12-27 08:58
The test should be fixed now, but there is a configuration issue.
msg383845 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-12-27 11:08
> New changeset dda12ad63e927e93d71462ad77cc84da55bada9b by Miss Islington (bot) in branch '3.9':
> bpo-42749: Fix testing bignum if Tkinter is compiled with Tk 8.4 and dynamic linked with Tk >= 8.5 (GH-23955)

test_tcl still fails on POWER6 AIX 3.9:
https://buildbot.python.org/all/#/builders/330/builds/226

======================================================================
FAIL: test_expr_bignum (test.test_tcl.TclTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/aixtools/buildarea/3.9.aixtools-aix-power6/build/Lib/test/test_tcl.py", line 451, in test_expr_bignum
    self.assertRaises(TclError, tcl.call, 'expr', str(2**1000))
AssertionError: TclError not raised by call
msg383975 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-12-29 10:56
New changeset 156b7f7052102ee1633a18e9a136ad8c38f66db0 by Serhiy Storchaka in branch 'master':
bpo-42749: Use dynamic version to test for unsupported bignum in Tk (GH-23966)
https://github.com/python/cpython/commit/156b7f7052102ee1633a18e9a136ad8c38f66db0
msg383977 - (view) Author: miss-islington (miss-islington) Date: 2020-12-29 11:16
New changeset 323cbb5531eb72527d0e3b02f28c1cdc5b7fce92 by Miss Islington (bot) in branch '3.8':
bpo-42749: Use dynamic version to test for unsupported bignum in Tk (GH-23966)
https://github.com/python/cpython/commit/323cbb5531eb72527d0e3b02f28c1cdc5b7fce92
msg383978 - (view) Author: miss-islington (miss-islington) Date: 2020-12-29 11:17
New changeset 7bdb3e08251894b49e7893db1dc4868e2656b342 by Miss Islington (bot) in branch '3.9':
bpo-42749: Use dynamic version to test for unsupported bignum in Tk (GH-23966)
https://github.com/python/cpython/commit/7bdb3e08251894b49e7893db1dc4868e2656b342
msg384006 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-12-29 14:10
test_tcl is passed: https://buildbot.python.org/all/#/builders/330/builds/228 .
msg384038 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-12-30 01:05
I confirm that test_tcl pass again on POWER6 AIX 3.9. Thanks Serhiy for the fix!

I checked the following build: https://buildbot.python.org/all/#/builders/330/builds/229
History
Date User Action Args
2022-04-11 14:59:39adminsetgithub: 86915
2020-12-30 01:05:10vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg384038

stage: patch review -> resolved
2020-12-29 14:10:10serhiy.storchakasetmessages: + msg384006
2020-12-29 11:17:47miss-islingtonsetmessages: + msg383978
2020-12-29 11:16:54miss-islingtonsetmessages: + msg383977
2020-12-29 10:56:28miss-islingtonsetpull_requests: + pull_request22832
2020-12-29 10:56:25serhiy.storchakasetmessages: + msg383975
2020-12-29 10:56:16miss-islingtonsetpull_requests: + pull_request22831
2020-12-27 13:32:22serhiy.storchakasetpull_requests: + pull_request22811
2020-12-27 11:08:51vstinnersetmessages: + msg383845
2020-12-27 08:58:34serhiy.storchakasetnosy: + Michael.Felt

messages: + msg383843
versions: + Python 3.8, Python 3.10
2020-12-27 08:56:49serhiy.storchakasetmessages: + msg383842
2020-12-27 08:32:39miss-islingtonsetmessages: + msg383840
2020-12-27 08:13:59miss-islingtonsetpull_requests: + pull_request22807
2020-12-27 08:13:54serhiy.storchakasetmessages: + msg383839
2020-12-27 08:13:52miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request22806
2020-12-26 12:12:10serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request22802
2020-12-26 11:47:39serhiy.storchakasetnosy: + David.Edelsohn
messages: + msg383803
2020-12-26 11:11:58vstinnercreate