classification
Title: Build fails on macOS when compiler doesn't define __has_builtin
Type: compile error Stage: resolved
Components: Build, macOS Versions: Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: jmr, miss-islington, ned.deily, ronaldoussoren
Priority: normal Keywords: patch

Created on 2020-12-20 18:27 by jmr, last changed 2021-01-04 11:01 by ned.deily. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 23873 merged jmr, 2020-12-20 18:35
PR 24090 merged miss-islington, 2021-01-04 10:37
Messages (4)
msg383437 - (view) Author: Joshua Root (jmr) * Date: 2020-12-20 18:27
The line in posixmodule.c that checks for __builtin_available is rejected by compilers that don't have __has_builtin. The second check needs to be in a nested #if.
msg384318 - (view) Author: miss-islington (miss-islington) Date: 2021-01-04 10:37
New changeset df21f502fdccec234282bf0a211af979fd23def4 by Joshua Root in branch 'master':
bpo-42692: fix __builtin_available check on older compilers (GH-23873)
https://github.com/python/cpython/commit/df21f502fdccec234282bf0a211af979fd23def4
msg384319 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2021-01-04 11:00
New changeset eedeaef1f22d27264ce9b031da80fe2485e85e69 by Miss Islington (bot) in branch '3.9':
bpo-42692: fix __builtin_available check on older compilers (GH-23873) (GH-24090)
https://github.com/python/cpython/commit/eedeaef1f22d27264ce9b031da80fe2485e85e69
msg384320 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2021-01-04 11:01
Thanks for the PR!
History
Date User Action Args
2021-01-04 11:01:55ned.deilysetstatus: open -> closed
resolution: fixed
messages: + msg384320

stage: patch review -> resolved
2021-01-04 11:00:49ned.deilysetmessages: + msg384319
2021-01-04 10:37:14miss-islingtonsetpull_requests: + pull_request22921
2021-01-04 10:37:05miss-islingtonsetnosy: + miss-islington
messages: + msg384318
2020-12-20 18:35:53jmrsetkeywords: + patch
stage: patch review
pull_requests: + pull_request22735
2020-12-20 18:27:40jmrcreate