classification
Title: os.statvfs_result doesn't show f_fsid
Type: behavior Stage:
Components: Library (Lib) Versions: Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: Rethan, christian.heimes
Priority: normal Keywords: patch

Created on 2020-11-25 10:06 by Rethan, last changed 2020-12-04 10:42 by Rethan.

Pull Requests
URL Status Linked Edit
PR 23511 open Rethan, 2020-11-25 10:13
Messages (4)
msg381811 - (view) Author: haoyixing (Rethan) * Date: 2020-11-25 10:06
From doc I see about os.statvfs "New in version 3.7: Added f_fsid.", but it doesn't show up when print an object os.statvfs returned. So I think maybe we can add the field when printing object.
msg381815 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2020-11-25 10:18
Changeset 96a5e50a5de3683b2afd6d680c7ecc4b525986f6 added a new struct member but did not increase PyStructSequence_Desc.n_in_sequence of
statvfs_result_desc. I'm not sure if the size of the sequence was not increased on purpose.

For reference the feature was added in bpo-32143.
msg381876 - (view) Author: haoyixing (Rethan) * Date: 2020-11-26 06:05
Under my mac and fedora test environment, calling statfs in C language as a non-privileged user both returned meaningful fsid. And in python os.statvfs(some_path).f_fsid can also show the f_fsid of path. So I didn't see any inconveniences so far if object print shows it.
msg382473 - (view) Author: haoyixing (Rethan) * Date: 2020-12-04 10:42
hi christian, is there any future suggestions?
History
Date User Action Args
2020-12-04 10:42:23Rethansetmessages: + msg382473
2020-11-26 06:05:27Rethansetmessages: + msg381876
2020-11-25 10:18:18christian.heimessetnosy: + christian.heimes

messages: + msg381815
stage: patch review ->
2020-11-25 10:13:48Rethansetkeywords: + patch
stage: patch review
pull_requests: + pull_request22397
2020-11-25 10:06:55Rethancreate