classification
Title: IDLE calltip.get_argspec: use inspect.getdoc, comment fob
Type: behavior Stage: resolved
Components: IDLE Versions: Python 3.10, Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: miss-islington, terry.reedy
Priority: normal Keywords: patch

Created on 2020-11-20 05:52 by terry.reedy, last changed 2020-11-20 07:30 by terry.reedy. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 23416 merged terry.reedy, 2020-11-20 06:36
PR 23417 merged miss-islington, 2020-11-20 06:59
PR 23418 merged miss-islington, 2020-11-20 06:59
Messages (4)
msg381462 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2020-11-20 05:52
Followup to PR-23393 of #1635741.  Use inspect.getdoc to get docstrings.  Restore test skipped in that PR and fix two that will fail because getdoc gets docstrings that are currently missed.

The line defining fob is only needed to get signatures for instances of classes with faulty getattr and __call__.  inspect.signature is allowed to fail for buggy objects, but this workaround makes it work anyway for CallA() and CallB() in test_buggy_getattr_class.  Add comment.
msg381463 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2020-11-20 06:59
New changeset 7ddbaa7a1b3e61847ee99658be6a7268a049e302 by Terry Jan Reedy in branch 'master':
bpo-42416: Use inspect.getdoc for IDLE calltips (GH-23416)
https://github.com/python/cpython/commit/7ddbaa7a1b3e61847ee99658be6a7268a049e302
msg381464 - (view) Author: miss-islington (miss-islington) Date: 2020-11-20 07:22
New changeset c076d488059c96e97936f4d669e32aea0994886f by Miss Islington (bot) in branch '3.8':
bpo-42416: Use inspect.getdoc for IDLE calltips (GH-23416)
https://github.com/python/cpython/commit/c076d488059c96e97936f4d669e32aea0994886f
msg381465 - (view) Author: miss-islington (miss-islington) Date: 2020-11-20 07:28
New changeset 4dd2112a1d26e03b605bed0f89e3678041ad1490 by Miss Islington (bot) in branch '3.9':
bpo-42416: Use inspect.getdoc for IDLE calltips (GH-23416)
https://github.com/python/cpython/commit/4dd2112a1d26e03b605bed0f89e3678041ad1490
History
Date User Action Args
2020-11-20 07:30:54terry.reedysetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-11-20 07:28:29miss-islingtonsetmessages: + msg381465
2020-11-20 07:22:37miss-islingtonsetmessages: + msg381464
2020-11-20 06:59:43miss-islingtonsetpull_requests: + pull_request22311
2020-11-20 06:59:35miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request22310
2020-11-20 06:59:18terry.reedysetmessages: + msg381463
2020-11-20 06:36:21terry.reedysetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request22309
2020-11-20 05:52:42terry.reedycreate