This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Make PCbuild/build.bat build x64 by default
Type: Stage: resolved
Components: Build, Windows Versions: Python 3.10, Python 3.9
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: steve.dower Nosy List: miss-islington, ned.deily, paul.moore, steve.dower, tim.golden, tim.peters, zach.ware
Priority: normal Keywords: patch

Created on 2020-11-12 22:50 by steve.dower, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 23275 merged steve.dower, 2020-11-13 23:25
PR 23325 merged steve.dower, 2020-11-16 22:18
PR 23372 merged miss-islington, 2020-11-18 17:25
PR 23373 merged steve.dower, 2020-11-18 17:30
Messages (8)
msg380858 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-11-12 22:50
Now that the 64-bit download is the default on, we should make the build command default to 64-bit as well.

This should only affect contributors, so should be non-controversial. But we should add a "-x86" option to the batch file as well.
msg380860 - (view) Author: Tim Peters (tim.peters) * (Python committer) Date: 2020-11-12 23:01
+1. If you're feeling more ambitious, it would also be good to change build.bat and rt.bat to use the same "which platform?" spellings and with the same defaults.
msg380942 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-11-13 23:26
I hope you'll find that PR suitable ambitious :)

It would really be nice to have proper Powershell scripts for these, but that would be a more significant rewrite (and probably require changing argument names...). I'm not *that* ambitious.
msg381360 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-11-18 17:24
New changeset 2156d964a12285280c533af1c96eb273c58451e6 by Steve Dower in branch 'master':
bpo-42336: Improve PCbuild batch files (GH-23275)
msg381361 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-11-18 17:24
New changeset 8b1f4cc4644869812ff7f210a7fcbe872d88846e by Steve Dower in branch '3.8':
bpo-42336: Improve PCbuild batch files (GH-23325)
msg381363 - (view) Author: miss-islington (miss-islington) Date: 2020-11-18 17:46
New changeset 37f6fe2c935a57cd1bd42c773aba255d8134cb61 by Miss Islington (bot) in branch '3.9':
bpo-42336: Improve PCbuild batch files (GH-23275)
msg381367 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-11-18 18:02
New changeset 9ae1742bdf85dc78788ae2d68ab5b02f67f69eb3 by Steve Dower in branch '3.7':
[3.7] bpo-42336: Improve PCbuild batch files (GH-23325) (GH-23373)
msg381513 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-11-21 01:10
We also updated the buildbot config to use the new options.
Date User Action Args
2022-04-11 14:59:38adminsetgithub: 86502
2020-11-21 01:10:15steve.dowersetstatus: open -> closed
messages: + msg381513

assignee: steve.dower
resolution: fixed
stage: patch review -> resolved
2020-11-18 18:02:00ned.deilysetnosy: + ned.deily
messages: + msg381367
2020-11-18 17:46:03miss-islingtonsetmessages: + msg381363
2020-11-18 17:30:14steve.dowersetpull_requests: + pull_request22266
2020-11-18 17:25:00miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request22265
2020-11-18 17:24:59steve.dowersetmessages: + msg381361
2020-11-18 17:24:43steve.dowersetmessages: + msg381360
2020-11-16 22:18:13steve.dowersetpull_requests: + pull_request22215
2020-11-13 23:26:23steve.dowersetmessages: + msg380942
2020-11-13 23:25:09steve.dowersetkeywords: + patch
stage: patch review
pull_requests: + pull_request22171
2020-11-12 23:01:33tim.peterssetnosy: + tim.peters
messages: + msg380860
2020-11-12 22:50:50steve.dowercreate