classification
Title: Check if generated files are up-to-date in Github Actions
Type: Stage: patch review
Components: Versions:
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: FFY00, vstinner
Priority: normal Keywords: patch

Created on 2020-10-30 17:22 by FFY00, last changed 2020-11-20 14:17 by vstinner.

Pull Requests
URL Status Linked Edit
PR 23042 merged FFY00, 2020-10-30 17:24
PR 23423 open vstinner, 2020-11-20 14:12
Messages (4)
msg379989 - (view) Author: Filipe Laíns (FFY00) * Date: 2020-10-30 17:23
https://github.com/python/core-workflow/issues/380
msg381482 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-11-20 14:14
New changeset d20b7ed9c1fabac3fdebb7ec362fe4f022a54639 by Filipe Laíns in branch 'master':
bpo-42212: Check if generated files are up-to-date in GitHub Actions (GH-23042)
https://github.com/python/cpython/commit/d20b7ed9c1fabac3fdebb7ec362fe4f022a54639
msg381483 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-11-20 14:15
Let's see how it goes on PRs for a few days, and later we can decide if it should be backported to 3.8 and 3.9 branches.
msg381484 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-11-20 14:17
While we are here... it might interesting to also run patchcheck.py on PRs using GitHub Actions:
https://mail.python.org/archives/list/python-dev@python.org/message/DKLD2VLHZ3F54WTKZ7JHKWBMOZ4N5TK7/

.travis.yml uses:

script:
  # Using the built Python as patchcheck.py is built around the idea of using
  # a checkout-build of CPython to know things like what base branch the changes
  # should be compared against.
  # Only run on Linux as the check only needs to be run once.
  - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then ./python Tools/scripts/patchcheck.py --travis $TRAVIS_PULL_REQUEST; fi
History
Date User Action Args
2020-11-20 14:17:08vstinnersetmessages: + msg381484
2020-11-20 14:15:04vstinnersetmessages: + msg381483
2020-11-20 14:14:24vstinnersetmessages: + msg381482
2020-11-20 14:12:06vstinnersetpull_requests: + pull_request22315
2020-10-30 17:24:15FFY00setkeywords: + patch
stage: patch review
pull_requests: + pull_request21961
2020-10-30 17:23:24FFY00setmessages: + msg379989
2020-10-30 17:22:37FFY00create